Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize platform name and sensor attributes/properties in readers #2994

Open
BENR0 opened this issue Nov 21, 2024 · 0 comments
Open

Standardize platform name and sensor attributes/properties in readers #2994

BENR0 opened this issue Nov 21, 2024 · 0 comments

Comments

@BENR0
Copy link
Collaborator

BENR0 commented Nov 21, 2024

Feature Request

Is your feature request related to a problem? Please describe.
Sometimes platform_name and/or sensor attributes are missing in DataArrays returned by readers (e.g. #2993)

Describe the solution you'd like
Every reader should put platform_name and sensor as attributes in DataArrays. Some readers (e.g. FCI even have properties regarding these values see:

@property
def spacecraft_name(self):
"""Return spacecraft name."""
return self.nc.attrs["platform"]
@property
def sensor_name(self):
"""Return instrument name."""
return self.nc.attrs["data_source"]
)

  • Ideally the platform_name and sensor attributes would align with the names from https://space.oscar.wmo.int/(satellites/instruments). An open question might be how to handle possible renaming e.g. when switching from commissioning to operational setup (e.g. currently space oscar is listing MTG-I1 which will be renamed to Meteosat-12).
  • Should readers also have these values as properties like in the FCI reader currently?

Describe any changes to existing user workflow
Should not directly affect useres

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant