-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to xr dataset merge error with conflicting values in coordinate #2827
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
==========================================
- Coverage 96.10% 96.10% -0.01%
==========================================
Files 377 377
Lines 55162 55177 +15
==========================================
+ Hits 53012 53026 +14
- Misses 2150 2151 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me except the type annotation on compat
which I've commented on inline. If that is resolved then this is good to merge.
The failing test output really doesn't help determine what is wrong/unequal for that test. |
Pull Request Test Coverage Report for Build 12180160048Details
💛 - Coveralls |
Fixes the merge error Problem by allowing to pass the
compat
argument.to_xarray_dataset
for Scenes containing data from seviri_l1b_nc reader #2179