-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: li missing platform name #2993
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2993 +/- ##
=======================================
Coverage 96.10% 96.10%
=======================================
Files 377 377
Lines 55162 55192 +30
=======================================
+ Hits 53012 53042 +30
Misses 2150 2150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11951131663Details
💛 - Coveralls |
Thanks @BENR0 , I've noticed this as well recently. Could we take the platform info from the filename and use the mapping as done for FCI here? satpy/satpy/readers/fci_l1c_nc.py Lines 205 to 209 in 1a7a342
Although the question of the platform name and the operational renaming to e.g. MET-12 is very valid... |
@ameraner Maybe we just wait till it is renamed to fix it? Shouldn't be that long till then I guess? ;-) |
Yeah, should only be a couple of weeks or so :) As you prefer, I'm ok also with merging this and update again later. satpy/satpy/readers/seviri_l1b_native.py Line 317 in d22d2b6
|
@ameraner Do you know if the name will eventually also be changed on https://space.oscar.wmo.int/satellites/ from MTG-I1 to Meteosat-12? |
I assume so, as the MSG satellites are also listed as Meteosat-XX. |
Thanks! The changes look good to me, however it seems that both the FCI and LI tests need to be updated.. |
@ameraner good point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This fixes the
DataArrays
returned by the li reader missing theplatform_name
attribute.AUTHORS.md
if not there already