-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix usage when trollsched is not installed #223
Fix usage when trollsched is not installed #223
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 95.96% 95.99% +0.02%
==========================================
Files 14 14
Lines 3272 3293 +21
==========================================
+ Hits 3140 3161 +21
Misses 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a unit test for the added lines if possible.
…hub.com/pnuu/trollflow2 into fix-trollsched-usage-when-not-installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for fixing this check and making the code better along the way!
The
check_valid_data_fraction()
doesn't have a check whether pytroll-schedule is installed or not.This PR adds the check, and makes the
get_scene_coverage()
helper function a private function to show it should not be called directly.check_valid_data_fraction
plugin does not check for pytroll-schedule availability #222flake8 trollflow2