You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The naming of attributes and classes need clarifying.
MoveItBase.notifier and MoveItBase.watchman handle the changes in the configuration file. This should have indication of their use
server.reload_config() has similarly named kwargs notifier_builder=None and manager=RequestManager that are used for detecting new files. The naming should indicate this. In addition, these are never used in any of the Trollmoves scripts, so maybe the could be removed altogether?
Both server.py and client.py implement EventHandler, only the one in server.py is used. Maybe this should be in utils.py?
MoveItBase has an attribute self._np, which is only used by the MoveItClient class in bin/move_it_client.py, but the publisher is stopped in move_it_base.MoveItBase.chains_stop(). This should be renamed (self._noisy_publisher?) and the whole class moved to trollmoves/client.py
MoveItServer in bin/move_it_server.py should be moved to trollmoves/server.py
The text was updated successfully, but these errors were encountered:
The naming of attributes and classes need clarifying.
MoveItBase.notifier
andMoveItBase.watchman
handle the changes in the configuration file. This should have indication of their useserver.reload_config()
has similarly named kwargsnotifier_builder=None
andmanager=RequestManager
that are used for detecting new files. The naming should indicate this. In addition, these are never used in any of the Trollmoves scripts, so maybe the could be removed altogether?server.py
andclient.py
implementEventHandler
, only the one inserver.py
is used. Maybe this should be inutils.py
?MoveItBase
has an attributeself._np
, which is only used by theMoveItClient
class inbin/move_it_client.py
, but the publisher is stopped inmove_it_base.MoveItBase.chains_stop()
. This should be renamed (self._noisy_publisher
?) and the whole class moved totrollmoves/client.py
MoveItServer
inbin/move_it_server.py
should be moved totrollmoves/server.py
The text was updated successfully, but these errors were encountered: