Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python CI versions to cover 3.10 - 3.12 #191

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Feb 16, 2024

Update CI Python versions to 3.10, 3.11 and 3.12.

@pnuu pnuu self-assigned this Feb 16, 2024
@pnuu pnuu requested a review from mraspaud as a code owner February 16, 2024 12:43
@pnuu
Copy link
Member Author

pnuu commented Feb 16, 2024

Ok, next hurdle is pyinotify which uses asyncore that is not available in 3.12 stdlib. There is an external package supplying this, but I think migrating to watchdog is the way to go. I'll create another issue about this.

@pnuu
Copy link
Member Author

pnuu commented Feb 16, 2024

#192

@pnuu
Copy link
Member Author

pnuu commented Feb 19, 2024

In short about test failures: #185 needs to be merged before we can start testing on Python 3.12.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (7c50b7b) to head (a52ee84).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   91.08%   91.12%   +0.04%     
==========================================
  Files          26       26              
  Lines        5370     5421      +51     
==========================================
+ Hits         4891     4940      +49     
- Misses        479      481       +2     
Flag Coverage Δ
unittests 91.12% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnuu pnuu force-pushed the update-python-ci-versions branch from d12efe1 to 4bc97d5 Compare February 27, 2024 19:02
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit a77c43c into pytroll:main Feb 28, 2024
6 checks passed
@pnuu pnuu deleted the update-python-ci-versions branch February 28, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants