Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make placeholder workaround less likely to be mangled by Google Translate #16

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Make placeholder workaround less likely to be mangled by Google Translate #16

merged 3 commits into from
Sep 17, 2024

Conversation

q--
Copy link
Owner

@q-- q-- commented Sep 17, 2024

Other improvements:

  • Make pluralization variant handling more robust by sending them to Google Translate separately
  • Some logging improvements.

q-- added 3 commits September 17, 2024 11:45
@q--
Make placeholder workaround more robust
5412ef2 
By using fake URLs instead of x0, x1 etc. Google Translate is much less
likely to mess them up.
@q--
Log language along with placeholder error message
fc9519f 
This makes it easier to find if you're translating multiple languages.
@q--
Inform the user of the language translated
5afb0ab
@q-- q-- merged commit 1f7eb1d into 2.x Sep 17, 2024
2 checks passed
@q-- q-- deleted the Make_placeholder_workaround_less_likely_to_be_mangled_by_Google_Translate branch September 17, 2024 09:55
@q-- q-- restored the Make_placeholder_workaround_less_likely_to_be_mangled_by_Google_Translate branch September 17, 2024 09:55
@q-- q-- deleted the Make_placeholder_workaround_less_likely_to_be_mangled_by_Google_Translate branch September 17, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@q--