Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade docs-site to React 19 #5299

Closed
martijnrusschen opened this issue Jan 5, 2025 · 6 comments · Fixed by #5300 · May be fixed by qburst/react-datepicker-3#42
Closed

Upgrade docs-site to React 19 #5299

martijnrusschen opened this issue Jan 5, 2025 · 6 comments · Fixed by #5300 · May be fixed by qburst/react-datepicker-3#42

Comments

@martijnrusschen
Copy link
Member

I tried upgrading but ran into some errors. Could use some help to complete the upgrade. Should hopefully be pretty straightforward.

@balajis-qb
Copy link
Contributor

balajis-qb commented Jan 6, 2025

I think as the main project is using react-18 and as we just try to update docs-site it's throwing an error

image

When I tried upgrading react-datepicker dependencies also to v19, it worked in my local

@martijnrusschen
Copy link
Member Author

The main project now has support for React 19 so that should be good, but we may have missed a place or 2

@martijnrusschen
Copy link
Member Author

I got it to work, and created a pull request.

@balajis-qb
Copy link
Contributor

But it's having typescript related issues. Hence many tests are failing

@martijnrusschen
Copy link
Member Author

Yeah saw that as well. Help is welcome in fixing those. There are about 10 checks failing right now.

@balajis-qb
Copy link
Contributor

balajis-qb commented Jan 6, 2025

@martijnrusschen I raised a type fixing PR to your react-19 branch - #5301

Let me know if it needs to be raised against the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants