Bug in synchronization of selection in the 'Review tool main view' and the editor

[chreex]

A file may appear in multiple source sets.

When the editor gets focus, the first hit is selected in the 'Review tool main view', even if the first hit is in a collapsed source set. This is acceptable if all the source sets are collapsed or the edited file is present only in a collapsed source set, but if only one source set is open (i. e. is in a non-collapsed state), containing the file, the file should be selected in that very source set.

There is a workaround indeed: hiding the unneeded source sets.

[agostoni]

In mentioned case, all occurrences of the file are selected, not only the first one (also in the already opened source sets, but probably the scroll position is set to first hit ).

The requirement could be modified this way:

• A collapsed set must be opened, if and only if it contains the file, and none of opened source sets contain the file (if this is true for more collapsed sets, all of them must be opened).
• The file must be selected in all opened source set. The first hit should be visible (set scroll position).

I feel the original solution is cleaner, simpler, and less error-prone, so I'm not sure, that this feature worth the effort.