Validation should actually say what's wrong

[lnicola]

I'm not involved in QGIS, but I've recently seen two users complaining on mantra-request about not being able to upload their archives because of the __pycache__ check. They were sure they didn't have any cache folders, but still got this error from the site.

Alas, they were both wrong, but the validator already know the path to the forbidden file(s) in the archive. It should include that in the error message instead of showing such an unhelpful error.

This can be implemented by including zname in the error message at

QGIS-Django/qgis-app/plugins/validator.py

Lines 187 to 198 in 08f01b4

	if zname.find(".pyc") != -1:
	raise ValidationError(
	_("For security reasons, zip file cannot contain .pyc file")
	)
	for forbidden_dir in ["__MACOSX", ".git", "__pycache__"]:
	if forbidden_dir in zname.split("/"):
	raise ValidationError(
	_(
	"For security reasons, zip file "
	"cannot contain '%s' directory" % (forbidden_dir,)
	)
	)

, but it will require updating the tests.

[Xpirix]

Please find the proposed fix for this at #387