Apply suggestions from code review

qgis · Dec 4, 2024 · 5e608c9 · 5e608c9
1 parent 2cf27b7
commit 5e608c9
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/src/analysis/processing/qgsalgorithmmergevector.cpp b/src/analysis/processing/qgsalgorithmmergevector.cpp
@@ -87,7 +87,7 @@ QVariantMap QgsMergeVectorAlgorithm::processAlgorithm( const QVariantMap &parame
 {
   const QList< QgsMapLayer * > layers = parameterAsLayerList( parameters, QStringLiteral( "LAYERS" ), context );
 
-  bool addSourceFields = parameterAsBool( parameters, QStringLiteral( "ADD_SOURCE_FIELDS" ), context );
+  const bool addSourceFields = parameterAsBool( parameters, QStringLiteral( "ADD_SOURCE_FIELDS" ), context );
 
   QgsFields outputFields;
   long totalFeatureCount = 0;
@@ -269,8 +269,6 @@ QVariantMap QgsMergeVectorAlgorithm::processAlgorithm( const QVariantMap &parame
       QgsAttributes destAttributes;
       for ( const QgsField &destField : outputFields )
       {
-        // add source layer information
-        if ( addSourceFields )  
         {
           if ( addLayerField && destField.name() == QLatin1String( "layer" ) )
           {
@@ -282,7 +280,6 @@ QVariantMap QgsMergeVectorAlgorithm::processAlgorithm( const QVariantMap &parame
             destAttributes.append( layerSource );
             continue;
           }
-        }
 
         QVariant destAttribute;
         const int sourceIndex = layerFields.lookupField( destField.name() );