Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for geofence feature #99

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix for geofence feature #99

merged 1 commit into from
Dec 10, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Dec 9, 2024

Fix for #95

  • Get the location filter from the request remote address, as QGIS doesn't send the lat and lon parameters
  • This location is only used by the spatial filter feature and won't be saved
  • Remove the filter related to lat and lon
  • Update unit tests

@Xpirix Xpirix requested review from dimasciput and timlinux December 9, 2024 11:35
timlinux
timlinux approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@timlinux timlinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me as long as we don't store the user IP address.

@Xpirix Xpirix merged commit 08c8cdc into qgis:master Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timlinux timlinux timlinux approved these changes

@dimasciput dimasciput Awaiting requested review from dimasciput

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xpirix @timlinux