Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate this repo with Qibo #96

Open
6 tasks
marekgluza opened this issue Nov 5, 2024 · 1 comment
Open
6 tasks

Consolidate this repo with Qibo #96

marekgluza opened this issue Nov 5, 2024 · 1 comment
Assignees
Labels
Not needed for journal submission question Further information is requested

Comments

@marekgluza
Copy link
Contributor

marekgluza commented Nov 5, 2024

Hi all,

initially, part of this repo was intended for the qibo repo
qiboteam/qibo#1294

The PR draft has already test functions for e.g. group commutators.

Option 1.
Don't add any further DBQA to qibo:

  • close 1294
  • accept that DBI in qibo is a model only for dense matrices
  • consider adding a dependancy on boostvqe for the gci model

Option 2.
Add GCI to Qibo because it has interesting circuit synthesis methods:

  • Focus on general features such as
    • group commutators,
    • GCI,
    • evolution oracles.
  • Keep here utils and additional documentation.

Option 3. First go with 1 and assign as onboarding project to someone to 2 port features to qibo and learn the PR process.

@marekgluza
Copy link
Contributor Author

see qiboteam/qibo#1523

  • qibo.models.dbi will be moved to a separate repo qiboteam/qibo-dbqa (similar to restructuring as QiboML)
  • the evolution oracles and the GCI transpiler should be moved there
  • the utilities for gradient descent etc should stay here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not needed for journal submission question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants