Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docformatter conflict w/ pre-commit 4 - 0.2 #1081

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

alecandido
Copy link
Member

Same of #1080 for 0.2

Waiting for a proper release which will fix the pre-commit 4 incompatibility
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.93%. Comparing base (486c6c7) to head (f09a678).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
- Coverage   51.95%   44.93%   -7.03%     
==========================================
  Files          63       63              
  Lines        2808     3247     +439     
==========================================
  Hits         1459     1459              
- Misses       1349     1788     +439     
Flag Coverage Δ
unittests 44.93% <ø> (-7.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should open an issue to revert once they release?

@alecandido
Copy link
Member Author

Maybe we should open an issue to revert once they release?

It's an option - but I was unsure because there are other two:

  • not sure if pre-commit will open anyhow the usual PR for updates (maybe no, since we're now following master)
  • I'm considering abandoning Pylint in favor of Ruff, which also provides formatting and docformatting, and it's quite actively developed

Thus, I postponed the problem. But we can of course open an issue to track it in general.

@alecandido alecandido merged commit d16f03f into main Oct 28, 2024
39 of 40 checks passed
@stavros11 stavros11 deleted the pre-commit-4-docformatter-0.2 branch October 29, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants