Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Custom envelope serializable #1102

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Make Custom envelope serializable #1102

merged 1 commit into from
Nov 15, 2024

Conversation

alecandido
Copy link
Member

Now that Custom is all the rage, I noticed there was a leftover related to the type of its attributes, preventing its serialization.

(To be fair, I actually discovered it by chance in the context of qiboteam/qibolab_platforms_qrc#201, only because it is used in the iqm5q parameters...)

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.87%. Comparing base (5836076) to head (a6fd145).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1102   +/-   ##
=======================================
  Coverage   50.87%   50.87%           
=======================================
  Files          63       63           
  Lines        2905     2905           
=======================================
  Hits         1478     1478           
  Misses       1427     1427           
Flag Coverage Δ
unittests 50.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecandido alecandido merged commit eca774d into main Nov 15, 2024
28 checks passed
@alecandido alecandido deleted the custom-attributes branch November 15, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants