Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: q2-fmt tutorial fixes #99

Merged
merged 8 commits into from
Sep 24, 2024
Merged

REF: q2-fmt tutorial fixes #99

merged 8 commits into from
Sep 24, 2024

Conversation

cherman2
Copy link
Contributor

@cherman2 cherman2 commented Sep 23, 2024 •
edited
Loading

Fixes two small issues with the q2-fmt peds identified while creating the q2-fmt tutorial

  1. q2-fmt peds now filters out NaN timepoints
  2. q2-fmt peds now filters out any donor sample that is in the metadata but not in the table with --p-filter-missing references.

Closes #69

colinvwood
colinvwood reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@colinvwood colinvwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests make sense to me

q2_fmt/_peds.py Outdated Show resolved Hide resolved
q2_fmt/_peds.py Outdated Show resolved Hide resolved
q2_fmt/_peds.py Show resolved Hide resolved
q2_fmt/_peds.py Outdated Show resolved Hide resolved
q2_fmt/tests/test_engraftment.py Show resolved Hide resolved
@colinvwood colinvwood merged commit f0574f7 into qiime2:dev Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinvwood colinvwood colinvwood left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
2024.10 🎃
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

q2-fmt should filter references that are in the column but not in the feature table.
2 participants
@cherman2 @colinvwood