Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the TSP implementation to work on any graph #646

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Dniskk
Copy link
Collaborator

@Dniskk Dniskk commented Nov 19, 2024

Summary

Details and comments

  • The TSP implementation now handles non-complete graphs correctly by:
    • Only summing over existing edges
    • Adding constraints to prevent using non-existent edges
    • Adding tests for non-complete graph scenarios

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


dennis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Dniskk Dniskk force-pushed the fix/628-enable-tsp-to-work-on-any-graph branch from c8a04b5 to c69874b Compare November 19, 2024 09:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11910572361

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.865%

Totals Coverage Status
Change from base Build 11829472558: 0.008%
Covered Lines: 4451
Relevant Lines: 4793

💛 - Coveralls

@TolisChal
Copy link
Collaborator

Thanks @Dniskk! All looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants