[QOLSVC-3826] Check for None before converting to string, and adding …

…more unit test cases
qld-gov-au · Nov 22, 2023 · 67c56df · 67c56df
1 parent ec59359
commit 67c56df
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/ckanext/data_qld/converters.py b/ckanext/data_qld/converters.py
@@ -12,6 +12,8 @@ def filesize_converter(value, context):
     :rtype: int
 
     """
+    if not value:
+        return None
     value = str(value)
     # remove whitespaces
     value = re.sub(' ', '', value)

diff --git a/ckanext/data_qld/tests/test_converters.py b/ckanext/data_qld/tests/test_converters.py
@@ -14,6 +14,8 @@ def test_filesize_converter():
                   '2 kb': 2048,
                   1024: 1024,
                   '1024, ': 1024,
+                  '1,000 bytes': 1000,
+                  '1,000 MB': 1048576000,
                   }
     for key, value in six.iteritems(test_cases):
         assert value == filesize_converter(key, {})