diff --git a/test/features/data_qld_theme.feature b/test/features/data_qld_theme.feature index e6dda9a8..5b38f112 100644 --- a/test/features/data_qld_theme.feature +++ b/test/features/data_qld_theme.feature @@ -92,7 +92,7 @@ Feature: Theme customisations Scenario: As a publisher, when I create a resource with an API entry, I can download it in various formats Given "TestOrgEditor" as the persona When I log in - And I create a dataset and resource with key-value parameters "license=other-open::private=False" and "format=CSV::upload=csv_resource.csv" + And I create a dataset and resource with key-value parameters "license=other-open" and "format=CSV::upload=csv_resource.csv" And I wait for 10 seconds And I press "Test Resource" Then I should see an element with xpath "//a[contains(string(), 'Data API')]" diff --git a/test/features/resource_availability.feature b/test/features/resource_availability.feature index 22bb003d..b4aa5b30 100644 --- a/test/features/resource_availability.feature +++ b/test/features/resource_availability.feature @@ -5,7 +5,7 @@ Feature: Re-identification risk governance acknowledgement or Resource visibilit Scenario: As a publisher, I can view hidden resources Given "TestOrgEditor" as the persona When I log in - And I create a dataset and resource with key-value parameters "name=package-with-invisible-resource::notes=Package with invisible resource::de_identified_data=NO::private=False" and "name=invisible-resource::resource_visible=FALSE" + And I create a dataset and resource with key-value parameters "name=package-with-invisible-resource::notes=Package with invisible resource::de_identified_data=NO" and "name=invisible-resource::resource_visible=FALSE" Then I should see "invisible-resource" And I should see "HIDDEN" When I press "invisible-resource" @@ -23,7 +23,7 @@ Feature: Re-identification risk governance acknowledgement or Resource visibilit Scenario: As an unprivileged user, I cannot see resources with privacy assessment requested and risk governance completed Given "TestOrgEditor" as the persona When I log in - And I create a dataset and resource with key-value parameters "name=package-with-assessed-resource::notes=Package with assessed resource::de_identified_data=NO::private=False" and "name=resource-for-assessment::request_privacy_assessment=YES::governance_acknowledgement=YES::resource_visible=TRUE" + And I create a dataset and resource with key-value parameters "name=package-with-assessed-resource::notes=Package with assessed resource::de_identified_data=NO" and "name=resource-for-assessment::request_privacy_assessment=YES::governance_acknowledgement=YES::resource_visible=TRUE" Then I should see "resource-for-assessment" Given "CKANUser" as the persona @@ -35,7 +35,7 @@ Feature: Re-identification risk governance acknowledgement or Resource visibilit Scenario: As an unprivileged user, I can see de-identified resources marked as visible without a privacy assessment Given "TestOrgEditor" as the persona When I log in - And I create a dataset and resource with key-value parameters "name=de-identified-package-with-unassessed-resource::de_identified_data=YES::private=False" and "name=visible-resource::request_privacy_assessment=NO::governance_acknowledgement=YES::resource_visible=TRUE" + And I create a dataset and resource with key-value parameters "name=de-identified-package-with-unassessed-resource::de_identified_data=YES" and "name=visible-resource::request_privacy_assessment=NO::governance_acknowledgement=YES::resource_visible=TRUE" Given "CKANUser" as the persona When I log out @@ -94,7 +94,7 @@ Feature: Re-identification risk governance acknowledgement or Resource visibilit Scenario: As an anonymous user, I can see resources without de-identified data Given "TestOrgEditor" as the persona When I log in - And I create a dataset and resource with key-value parameters "name=package-without-de-identified-data::de_identified_data=NO::private=False" and "name=visible-resource::governance_acknowledgement=NO::resource_visible=TRUE" + And I create a dataset and resource with key-value parameters "name=package-without-de-identified-data::de_identified_data=NO" and "name=visible-resource::governance_acknowledgement=NO::resource_visible=TRUE" When I log out And I go to dataset "package-without-de-identified-data" diff --git a/test/features/schema_generation.feature b/test/features/schema_generation.feature index 7faee434..1c5a8a8e 100644 --- a/test/features/schema_generation.feature +++ b/test/features/schema_generation.feature @@ -5,7 +5,7 @@ Feature: Schema Generation Scenario: As a publisher, when I visit my resource, I can generate a validation schema for it Given "TestOrgEditor" as the persona When I log in - And I create a dataset and resource with key-value parameters "notes=package-with-csv-res::schema_json=default::private=False" and "upload=default::format=CSV" + And I create a dataset and resource with key-value parameters "notes=package-with-csv-res::schema_json=default" and "upload=default::format=CSV" And I take a debugging screenshot And I go to the first resource in the dataset And I take a debugging screenshot @@ -44,7 +44,7 @@ Feature: Schema Generation Scenario: System actions following the selection of the set as dataset default dropdown option on the manage data schema GUI page Given "TestOrgEditor" as the persona When I log in - And I create a dataset and resource with key-value parameters "notes=apply-for-dataset-schema::schema_json=default::private=False" and "upload=default::format=CSV" + And I create a dataset and resource with key-value parameters "notes=apply-for-dataset-schema::schema_json=default" and "upload=default::format=CSV" And I go to the first resource in the dataset And I reload page every 3 seconds until I see an element with xpath "//*[string() = 'Data Dictionary']" but not more than 6 times And I visit resource schema generation page @@ -60,7 +60,7 @@ Feature: Schema Generation Scenario: System actions following the selection of the validate only this resource dropdown option on the manage data schema GUI page Given "TestOrgEditor" as the persona When I log in - And I create a dataset and resource with key-value parameters "notes=apply-for-resource-schema::schema_json=default::private=False" and "upload=default::format=CSV" + And I create a dataset and resource with key-value parameters "notes=apply-for-resource-schema::schema_json=default" and "upload=default::format=CSV" And I go to the first resource in the dataset And I reload page every 3 seconds until I see an element with xpath "//*[string() = 'Data Dictionary']" but not more than 6 times And I visit resource schema generation page diff --git a/test/features/steps/steps.py b/test/features/steps/steps.py index 997fd1c2..b9d21452 100644 --- a/test/features/steps/steps.py +++ b/test/features/steps/steps.py @@ -384,7 +384,11 @@ def _create_dataset_from_params(context, params): When I visit "/dataset/new" And I fill in default dataset fields """) - for key, value in _parse_params(params): + entries = _parse_params(params) + # Make datasets public by default + if 'private' not in entries: + params['private'] = "False" + for key, value in entries: if key == "name": # 'name' doesn't need special input, but we want to remember it context.execute_steps(u"""