Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QOLSVC-5123] handle empty cells past end of row #89

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[QOLSVC-5123] handle empty cells past end of row #89

merged 1 commit into from
Mar 8, 2024

Conversation

ThrawnCA
Copy link

@ThrawnCA ThrawnCA commented Mar 8, 2024

  • Excel tends to generate files with lots of extra commas at the end of every row. The header row ignores them, so data rows need to be able to ignore them as well.
  • Also strip trailing whitespace from headers after truncating them, in case the truncation exposed some, see strip extra space for column name ckan/ckanext-xloader#210

@ThrawnCA
[QOLSVC-5123] handle empty cells past end of row
b1ef90a 
- Excel tends to generate files with lots of extra commas at the end of every row.
The header row ignores them, so data rows need to be able to ignore them as well.
- Also strip trailing whitespace from headers after truncating them, in case the truncation exposed some,
see ckan#210
@ThrawnCA ThrawnCA merged commit 7857c1a into develop Mar 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duttonw duttonw duttonw approved these changes

@kundupz kundupz Awaiting requested review from kundupz

@chris-randall-qol chris-randall-qol Awaiting requested review from chris-randall-qol

@zmacca zmacca Awaiting requested review from zmacca

@RossWebsterWork RossWebsterWork Awaiting requested review from RossWebsterWork

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThrawnCA @duttonw