Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StackWalker to extract caller data when using J9+ to improve cpu performance #898

Open
qsLI opened this issue Dec 28, 2024 · 2 comments

Comments

@qsLI
Copy link

qsLI commented Dec 28, 2024

Logback uses Throwable.getStackTrace() method to calculate caller info which will get all stacktraces and causing performance issue.

image

code location:

StackTraceElement[] steArray = t.getStackTrace();

some discussion:

jdk9 introduces a new api ( StackWalker JEP 259: Stack-Walking API ) allows to get only needed StackTraceElement. LOG4J already supported StackWalker:

Do we have any plan to support StackWalker?

@be-hase
Copy link

be-hase commented Feb 25, 2025

I also feel that this point is an issue. Since StackWalker is more efficient, I believe this is a meaningful improvement.

@ceki
Copy link
Member

ceki commented Feb 25, 2025

In several tests I performed, StackWalker was not faster. However, I will look into this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants