From c63a840d8d62b87ed64bf6349ce810b5714ab32e Mon Sep 17 00:00:00 2001
From: Ceki Gulcu <ceki@qos.ch>
Date: Tue, 2 Jan 2024 19:40:21 +0100
Subject: [PATCH] revert to mixed jdk 8 and 9 requirement

Signed-off-by: Ceki Gulcu <ceki@qos.ch>
---
 jcl-over-slf4j-blackbox/pom.xml               |  2 +-
 .../src/main/{java => java9}/module-info.java |  0
 .../src/main/{java => java9}/module-info.java |  0
 log4j-over-slf4j-blackbox/pom.xml             |  2 +-
 .../src/main/{java => java9}/module-info.java |  0
 parent/pom.xml                                | 30 ++++++++-
 pom.xml                                       | 64 +++++++++++++++++--
 slf4j-api/pom.xml                             | 28 +++++++-
 .../org/slf4j/spi/NOPLoggingEventBuilder.java |  2 +-
 .../src/main/{java => java9}/module-info.java |  0
 slf4j-ext/pom.xml                             |  2 +-
 slf4j-jdk-platform-logging/pom.xml            | 62 +++++++++---------
 slf4j-jdk14/pom.xml                           | 29 +++++++++
 .../src/main/{java => java9}/module-info.java |  0
 slf4j-nop/pom.xml                             | 26 ++++++++
 .../src/main/{java => java9}/module-info.java |  0
 .../src/main/{java => java9}/module-info.java |  0
 slf4j-simple/pom.xml                          | 29 +++++++++
 .../src/main/{java => java9}/module-info.java |  0
 slf4j-testing/pom.xml                         | 22 ++++++-
 20 files changed, 254 insertions(+), 44 deletions(-)
 rename jcl-over-slf4j/src/main/{java => java9}/module-info.java (100%)
 mode change 100755 => 100644
 rename jul-to-slf4j/src/main/{java => java9}/module-info.java (100%)
 rename log4j-over-slf4j/src/main/{java => java9}/module-info.java (100%)
 mode change 100755 => 100644
 rename slf4j-api/src/main/{java => java9}/module-info.java (100%)
 rename slf4j-jdk14/src/main/{java => java9}/module-info.java (100%)
 rename slf4j-nop/src/main/{java => java9}/module-info.java (100%)
 mode change 100755 => 100644
 rename slf4j-reload4j/src/main/{java => java9}/module-info.java (100%)
 rename slf4j-simple/src/main/{java => java9}/module-info.java (100%)
 mode change 100755 => 100644

diff --git a/jcl-over-slf4j-blackbox/pom.xml b/jcl-over-slf4j-blackbox/pom.xml
index 76174fcc5..1e92eda1a 100644
--- a/jcl-over-slf4j-blackbox/pom.xml
+++ b/jcl-over-slf4j-blackbox/pom.xml
@@ -26,7 +26,7 @@
   </licenses>
 
   <properties>
-
+    <jdk.version>${jdk9.version}</jdk.version>
   </properties>
 
   <dependencies>
diff --git a/jcl-over-slf4j/src/main/java/module-info.java b/jcl-over-slf4j/src/main/java9/module-info.java
old mode 100755
new mode 100644
similarity index 100%
rename from jcl-over-slf4j/src/main/java/module-info.java
rename to jcl-over-slf4j/src/main/java9/module-info.java
diff --git a/jul-to-slf4j/src/main/java/module-info.java b/jul-to-slf4j/src/main/java9/module-info.java
similarity index 100%
rename from jul-to-slf4j/src/main/java/module-info.java
rename to jul-to-slf4j/src/main/java9/module-info.java
diff --git a/log4j-over-slf4j-blackbox/pom.xml b/log4j-over-slf4j-blackbox/pom.xml
index b7e1784db..7a37ae3d1 100644
--- a/log4j-over-slf4j-blackbox/pom.xml
+++ b/log4j-over-slf4j-blackbox/pom.xml
@@ -26,7 +26,7 @@
   </licenses>
 
   <properties>
-
+    <jdk.version>${jdk9.version}</jdk.version>
   </properties>
 
   <dependencies>
diff --git a/log4j-over-slf4j/src/main/java/module-info.java b/log4j-over-slf4j/src/main/java9/module-info.java
old mode 100755
new mode 100644
similarity index 100%
rename from log4j-over-slf4j/src/main/java/module-info.java
rename to log4j-over-slf4j/src/main/java9/module-info.java
diff --git a/parent/pom.xml b/parent/pom.xml
index 5009f5cdc..7e17a164a 100644
--- a/parent/pom.xml
+++ b/parent/pom.xml
@@ -29,9 +29,12 @@
     <project.build.outputTimestamp>2023-12-28T23:04:51Z</project.build.outputTimestamp>
     <latest.1.version>1.7.36</latest.1.version>
     <!-- java.util.ServiceLoader requires Java 6 -->
-    <jdk.version>11</jdk.version>
+    <jdk.version>8</jdk.version>
+    <!-- used in test modules, unpublished modules or where it does not matter -->
+    <jdk9.version>9</jdk9.version>
     <maven.compiler.source>${jdk.version}</maven.compiler.source>
     <maven.compiler.target>${jdk.version}</maven.compiler.target>
+
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <project.build.resourceEncoding>UTF-8</project.build.resourceEncoding>
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
@@ -145,6 +148,31 @@
               <release>${jdk.version}</release>
             </configuration>
           </execution>
+
+          <execution>
+            <id>default-testCompile</id>
+            <goals>
+              <goal>testCompile</goal>
+            </goals>
+            <configuration>
+              <release>${jdk.version}</release>
+            </configuration>
+          </execution>
+
+          <execution>
+            <id>module-compile</id>
+            <phase>compile</phase>
+            <goals>
+              <goal>compile</goal>
+            </goals>
+            <configuration>
+              <release>9</release>
+              <compileSourceRoots>
+                <compileSourceRoot>${project.basedir}/src/main/java9</compileSourceRoot>
+              </compileSourceRoots>
+              <multiReleaseOutput>true</multiReleaseOutput>
+            </configuration>
+          </execution>
         </executions>
 
       </plugin>
diff --git a/pom.xml b/pom.xml
index 452a38f8d..a5a3872c6 100755
--- a/pom.xml
+++ b/pom.xml
@@ -45,11 +45,11 @@
     <module>jcl-over-slf4j-blackbox</module>
     <module>log4j-over-slf4j</module>
     <module>log4j-over-slf4j-blackbox</module>
-    <module>jul-to-slf4j</module>
-    <module>jul-to-slf4j-blackbox</module>
-    <module>osgi-over-slf4j</module>
-    <module>integration</module>
-    <module>slf4j-migrator</module>
+<!--    <module>jul-to-slf4j</module>-->
+<!--    <module>jul-to-slf4j-blackbox</module>-->
+<!--    <module>osgi-over-slf4j</module>-->
+<!--    <module>integration</module>-->
+<!--    <module>slf4j-migrator</module>-->
   </modules>
 
   <dependencyManagement>
@@ -166,7 +166,7 @@
         <configuration>
           <verbose>true</verbose>
           <skippedModules>
-            slf4j-testing,slf4j-ext,log4j-over-slf4j,log4j-over-slf4j-blackbox,jul-to-slf4j-blackbox,slf4j-migrator,osgi-over-slf4j
+            slf4j-testing,slf4j-jdk-platform-logging,jcl-over-slf4j-blackbox,log4j-over-slf4j-blackbox,jul-to-slf4j-blackbox,slf4j-migrator,osgi-over-slf4j
           </skippedModules>
           <detectLinks>true</detectLinks>
           <doctitle>SLF4J project modules 2.1.0-alpha0</doctitle>
@@ -176,6 +176,58 @@
           <additionalOptions>
             <additionalOption>-Xdoclint:none</additionalOption>
           </additionalOptions>
+          <groups>
+            <group>
+              <title>SLF4J API packages</title>
+              <packages>org.slf4j:org.slf4j.spi:org.slf4j.event:org.slf4j.helpers</packages>
+            </group>
+
+            <group>
+              <title>slf4j-simple package</title>
+              <packages>org.slf4j.simple</packages>
+            </group>
+
+            <group>
+              <title>slf4j-nop package</title>
+              <packages>org.slf4j.nop</packages>
+            </group>
+
+
+            <group>
+              <title>slf4j-jdk14 package</title>
+              <packages>org.slf4j.jul</packages>
+            </group>
+
+
+            <group>
+              <title>slf4j-reload4j package</title>
+              <packages>org.slf4j.reload4j</packages>
+            </group>
+
+
+            <group>
+              <title>SLF4J extensions</title>
+              <packages>
+                org.slf4j.cal10n:org.slf4j.profiler:org.slf4j.ext:org.slf4j.instrumentation:org.slf4j.agent
+              </packages>
+            </group>
+
+            <group>
+              <title>Jakarta Commons Logging packages</title>
+              <packages>org.apache.commons.*</packages>
+            </group>
+
+            <group>
+              <title>java.util.logging (JUL) to SLF4J bridge</title>
+              <packages>org.slf4j.bridge</packages>
+            </group>
+
+            <group>
+              <title>log4j-over-slf4j redirection</title>
+              <packages>org.apache.log4j:org.apache.log4j.*</packages>
+            </group>
+          </groups>
+
         </configuration>
       </plugin>
     </plugins>
diff --git a/slf4j-api/pom.xml b/slf4j-api/pom.xml
index ea3baaac5..ee9851732 100755
--- a/slf4j-api/pom.xml
+++ b/slf4j-api/pom.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
 
   <modelVersion>4.0.0</modelVersion>
 
@@ -59,7 +59,8 @@
         <artifactId>maven-bundle-plugin</artifactId>
         <configuration>
           <instructions>
-            <Import-Package>org.slf4j.spi;version="${range;[===,+);${version_cleanup;${project.version}}}"</Import-Package>
+            <Import-Package>org.slf4j.spi;version="${range;[===,+);${version_cleanup;${project.version}}}"
+            </Import-Package>
             <!-- Export the client/user package of slf4j-api version 1 to make the slf4j-api bundle in version 2 usable for bundles that only import slf4j-1.x -->
             <_exportcontents><![CDATA[
               *,\
@@ -74,8 +75,29 @@
         </configuration>
       </plugin>
 
-    </plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>${maven-compiler-plugin.version}</version>
+        <executions>
 
+          <execution>
+            <id>module-compile</id>
+            <phase>compile</phase>
+            <goals>
+              <goal>compile</goal>
+            </goals>
+            <configuration>
+              <release>${jdk9.version}</release>
+              <compileSourceRoots>
+                <compileSourceRoot>${project.basedir}/src/main/java9</compileSourceRoot>
+              </compileSourceRoots>
+              <multiReleaseOutput>true</multiReleaseOutput>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
   </build>
 
 </project>
diff --git a/slf4j-api/src/main/java/org/slf4j/spi/NOPLoggingEventBuilder.java b/slf4j-api/src/main/java/org/slf4j/spi/NOPLoggingEventBuilder.java
index 6c9df405a..95bc489aa 100755
--- a/slf4j-api/src/main/java/org/slf4j/spi/NOPLoggingEventBuilder.java
+++ b/slf4j-api/src/main/java/org/slf4j/spi/NOPLoggingEventBuilder.java
@@ -11,7 +11,7 @@
  * <p></p>
  * <p>As the name indicates, the methods in this class do nothing. In case a return value is expected, a singleton,
  * i.e. the unique instance of this class, is returned.
- * </p
+ * </p>
  * <p></p>
  * <p>Note that the default implementations of {@link Logger#atTrace()}, {@link Logger#atDebug()} , {@link Logger#atInfo()},
  * {@link Logger#atWarn()}  and {@link Logger#atError()}, return an instance of {@link NOPLoggingEventBuilder}
diff --git a/slf4j-api/src/main/java/module-info.java b/slf4j-api/src/main/java9/module-info.java
similarity index 100%
rename from slf4j-api/src/main/java/module-info.java
rename to slf4j-api/src/main/java9/module-info.java
diff --git a/slf4j-ext/pom.xml b/slf4j-ext/pom.xml
index aae107688..c83a3ce5b 100755
--- a/slf4j-ext/pom.xml
+++ b/slf4j-ext/pom.xml
@@ -67,7 +67,7 @@
         <configuration>
           <archive>
             <manifestEntries>
-              <Automatic-Module-Name>org.slf4j.ext</Automatic-Module-Name>
+<!--              <Automatic-Module-Name>org.slf4j.ext</Automatic-Module-Name>-->
               <Premain-Class>org.slf4j.agent.AgentPremain</Premain-Class>
               <!-- what is the proper way to specify the maven full name? /ravn -->
               <Boot-Class-Path>../../../../javassist/javassist/3.4.GA/javassist-3.4.GA.jar javassist-3.4.GA.jar javassist.jar</Boot-Class-Path>
diff --git a/slf4j-jdk-platform-logging/pom.xml b/slf4j-jdk-platform-logging/pom.xml
index 349704a79..b3c5e511a 100644
--- a/slf4j-jdk-platform-logging/pom.xml
+++ b/slf4j-jdk-platform-logging/pom.xml
@@ -19,6 +19,10 @@
 
   <url>https://www.slf4j.org</url>
 
+  <properties>
+    <jdk.version>${jdk9.version}</jdk.version>
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>org.slf4j</groupId>
@@ -36,35 +40,35 @@
   <build>
     <plugins>
       <!-- target Java 9+ -->
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-compiler-plugin</artifactId>
-        <version>${maven-compiler-plugin.version}</version>
-        <executions>
-          <execution>
-            <id>default-compile</id>
-            <goals>
-              <goal>compile</goal>
-            </goals>
-            <configuration>
-              <source>9</source>
-              <target>9</target>
-              <release>9</release>
-            </configuration>            
-          </execution>
-          <execution>
-            <id>default-testCompile</id>
-            <goals>
-              <goal>testCompile</goal> 
-            </goals>
-            <configuration>
-              <source>9</source>
-              <target>9</target>
-              <release>9</release>
-            </configuration>            
-          </execution> 
-        </executions>        
-      </plugin>
+<!--      <plugin>-->
+<!--        <groupId>org.apache.maven.plugins</groupId>-->
+<!--        <artifactId>maven-compiler-plugin</artifactId>-->
+<!--        <version>${maven-compiler-plugin.version}</version>-->
+<!--        <executions>-->
+<!--          <execution>-->
+<!--            <id>default-compile</id>-->
+<!--            <goals>-->
+<!--              <goal>compile</goal>-->
+<!--            </goals>-->
+<!--            <configuration>-->
+<!--              <source>9</source>-->
+<!--              <target>9</target>-->
+<!--              <release>9</release>-->
+<!--            </configuration>            -->
+<!--          </execution>-->
+<!--          <execution>-->
+<!--            <id>default-testCompile</id>-->
+<!--            <goals>-->
+<!--              <goal>testCompile</goal> -->
+<!--            </goals>-->
+<!--            <configuration>-->
+<!--              <source>9</source>-->
+<!--              <target>9</target>-->
+<!--              <release>9</release>-->
+<!--            </configuration>            -->
+<!--          </execution> -->
+<!--        </executions>        -->
+<!--      </plugin>-->
 
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
diff --git a/slf4j-jdk14/pom.xml b/slf4j-jdk14/pom.xml
index 5c59ff474..a56e07f6c 100755
--- a/slf4j-jdk14/pom.xml
+++ b/slf4j-jdk14/pom.xml
@@ -38,4 +38,33 @@
 
   </dependencies>
 
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>${maven-compiler-plugin.version}</version>
+        <executions>
+
+          <execution>
+            <id>module-compile</id>
+            <phase>compile</phase>
+            <goals>
+              <goal>compile</goal>
+            </goals>
+            <configuration>
+              <release>${jdk9.version}</release>
+              <compileSourceRoots>
+                <compileSourceRoot>${project.basedir}/src/main/java9</compileSourceRoot>
+              </compileSourceRoots>
+              <multiReleaseOutput>true</multiReleaseOutput>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+
+
+  </build>
+
 </project>
diff --git a/slf4j-jdk14/src/main/java/module-info.java b/slf4j-jdk14/src/main/java9/module-info.java
similarity index 100%
rename from slf4j-jdk14/src/main/java/module-info.java
rename to slf4j-jdk14/src/main/java9/module-info.java
diff --git a/slf4j-nop/pom.xml b/slf4j-nop/pom.xml
index 208b7a4fe..d89f1fe2c 100755
--- a/slf4j-nop/pom.xml
+++ b/slf4j-nop/pom.xml
@@ -38,4 +38,30 @@
     </dependency>
   </dependencies>
 
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>${maven-compiler-plugin.version}</version>
+        <executions>
+
+          <execution>
+            <id>module-compile</id>
+            <phase>compile</phase>
+            <goals>
+              <goal>compile</goal>
+            </goals>
+            <configuration>
+              <release>${jdk9.version}</release>
+              <compileSourceRoots>
+                <compileSourceRoot>${project.basedir}/src/main/java9</compileSourceRoot>
+              </compileSourceRoots>
+              <multiReleaseOutput>true</multiReleaseOutput>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
 </project>
diff --git a/slf4j-nop/src/main/java/module-info.java b/slf4j-nop/src/main/java9/module-info.java
old mode 100755
new mode 100644
similarity index 100%
rename from slf4j-nop/src/main/java/module-info.java
rename to slf4j-nop/src/main/java9/module-info.java
diff --git a/slf4j-reload4j/src/main/java/module-info.java b/slf4j-reload4j/src/main/java9/module-info.java
similarity index 100%
rename from slf4j-reload4j/src/main/java/module-info.java
rename to slf4j-reload4j/src/main/java9/module-info.java
diff --git a/slf4j-simple/pom.xml b/slf4j-simple/pom.xml
index a5b849070..c64255636 100755
--- a/slf4j-simple/pom.xml
+++ b/slf4j-simple/pom.xml
@@ -19,6 +19,7 @@
 
   <properties>
     <module-name>org.slf4j.simple</module-name>
+
     <slf4j.provider.implementation>org.slf4j.simple.SimpleServiceProvider</slf4j.provider.implementation>
     <slf4j.provider.type>simple</slf4j.provider.type>
   </properties>
@@ -38,4 +39,32 @@
 
   </dependencies>
 
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>${maven-compiler-plugin.version}</version>
+        <executions>
+
+          <execution>
+            <id>module-compile</id>
+            <phase>compile</phase>
+            <goals>
+              <goal>compile</goal>
+            </goals>
+            <configuration>
+              <release>${jdk9.version}</release>
+              <compileSourceRoots>
+                <compileSourceRoot>${project.basedir}/src/main/java9</compileSourceRoot>
+              </compileSourceRoots>
+              <multiReleaseOutput>true</multiReleaseOutput>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+
+  </build>
+
 </project>
diff --git a/slf4j-simple/src/main/java/module-info.java b/slf4j-simple/src/main/java9/module-info.java
old mode 100755
new mode 100644
similarity index 100%
rename from slf4j-simple/src/main/java/module-info.java
rename to slf4j-simple/src/main/java9/module-info.java
diff --git a/slf4j-testing/pom.xml b/slf4j-testing/pom.xml
index 19127c061..7a2d2af6b 100644
--- a/slf4j-testing/pom.xml
+++ b/slf4j-testing/pom.xml
@@ -14,11 +14,13 @@
   <artifactId>slf4j-testing</artifactId>
   <packaging>jar</packaging>
   <name>SLF4J Common Testing</name>
-  <description>SLF4J Common testing </description>
+  <description>SLF4J Common testing</description>
   <url>http://www.slf4j.org</url>
 
   <properties>
+    <jdk.version>${jdk9.version}</jdk.version>
     <module-name>org.slf4j.testing</module-name>
+    <maven.compiler.release>${jdk9.version}</maven.compiler.release>
   </properties>
 
   <dependencies>
@@ -44,6 +46,24 @@
           <skip>true</skip>
         </configuration>
       </plugin>
+
+<!--      <plugin>-->
+<!--        <groupId>org.apache.maven.plugins</groupId>-->
+<!--        <artifactId>maven-compiler-plugin</artifactId>-->
+<!--        <version>${maven-compiler-plugin.version}</version>-->
+
+<!--        <executions>-->
+<!--          <execution>-->
+<!--            <id>default-compile</id>-->
+<!--            <goals>-->
+<!--              <goal>compile</goal>-->
+<!--            </goals>-->
+<!--            <configuration combine.self="override">-->
+<!--              <release>${jdk9.version}</release>-->
+<!--            </configuration>-->
+<!--          </execution>-->
+<!--        </executions>-->
+<!--      </plugin>-->
     </plugins>
   </build>
 </project>