Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanity check on cell_size #35

Open
qrohlf opened this issue Apr 8, 2015 · 2 comments
Open

sanity check on cell_size #35

qrohlf opened this issue Apr 8, 2015 · 2 comments
Labels

Comments

@qrohlf
Copy link
Owner

qrohlf commented Apr 8, 2015

The current sanity checks for cell_size are not sufficient, it is still possible to create an infinite loop by passing in a string (i.e. "40" instead of 40) for cell_size.

Oops.

@qrohlf
Copy link
Owner Author

qrohlf commented Mar 31, 2016

This may also apply to width/height/etc. Bugfix will be to define some sane constraints for how large/small each value can be and then throw an exception if arguments are invalid or of the wrong type.

@qrohlf qrohlf removed their assignment Jul 19, 2017
@Saucistophe
Copy link
Contributor

I concur with the need for a global sanity check.
I set a huge value for width, just to see what would happen, saw the memory increase quickly, then waived desperately as my OS slowly froze to death.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants