Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qss theme from qtum core #106

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

akshaynexus
Copy link

@akshaynexus akshaynexus commented Jan 10, 2020

This is a attempt at Adding qtum-core wallet styling to the electrum wallet.
Not sure if all themes should be supported in this like the core walelt or just one would suffice.

@icodeface
Copy link
Collaborator

thanks for contributing, but got some xxx does not have a property named "showGrid", hope this can be fixed, and make it an optional choice in "Preference" => "General" => "Color theme" will be better.

@akshaynexus
Copy link
Author

Ok

@akshaynexus
Copy link
Author

Added theme selection options to ui,needs the showgrid fixes,but do test the ui and let me know if any changes are required
if not then ill proceed to fix the showgrid issues

@icodeface
Copy link
Collaborator

icodeface commented Jan 11, 2020

good job, most of them are good, just some details need to adjust.
The alignment of right buttons inside the address edit in "Send" page are affected, and I think we can keep border-radius of QLineEdit the original size.

@akshaynexus
Copy link
Author

Will update the themeswitcher to Update the theme without restarting,looks like electrum stuck with on start theme switching for some reason even when on teh go change of stylesheets is possible

@akshaynexus
Copy link
Author

Let me know if any changes is needed.

@icodeface
Copy link
Collaborator

Hi , @akshaynexus
please check:

good job, most of them are good, just some details need to adjust.
The alignment of right buttons inside the address edit in "Send" page are affected, and I think we can keep border-radius of QLineEdit the original size.

and there are some xxx does not have a property named "showGrid" warnings when using "Qtum Dark"

@akshaynexus
Copy link
Author

Alright,will do the required updates soon.

@icodeface icodeface force-pushed the master branch 2 times, most recently from fdb54e2 to 3cd3fc1 Compare April 15, 2020 03:53
@icodeface icodeface force-pushed the master branch 4 times, most recently from 1d01cfa to 628be96 Compare July 24, 2020 03:48
@icodeface icodeface force-pushed the master branch 2 times, most recently from b70a2b3 to e7ad5bc Compare August 4, 2020 13:04
@icodeface icodeface force-pushed the master branch 6 times, most recently from 41fd4fd to 352d2b0 Compare September 7, 2020 11:11
@icodeface icodeface force-pushed the master branch 2 times, most recently from 5265cd5 to 84cd9d3 Compare September 7, 2020 14:16
@icodeface icodeface force-pushed the master branch 2 times, most recently from 7389ba2 to 79f062a Compare September 15, 2020 04:21
@davidmerwin
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants