Skip to content

Commit ef1779b

Browse files
committed
fix main build
1 parent 2c33917 commit ef1779b

File tree

6 files changed

+15
-12
lines changed

6 files changed

+15
-12
lines changed

.github/workflows/MainDistributionPipeline.yml

+8-7
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@ concurrency:
1515
cancel-in-progress: true
1616

1717
jobs:
18-
duckdb-next-build:
19-
name: Build extension binaries (next)
20-
uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main
21-
with:
22-
duckdb_version: main
23-
ci_tools_version: main
24-
extension_name: chsql
18+
# Temporarily disabled because main is broken
19+
# duckdb-next-build:
20+
# name: Build extension binaries (next)
21+
# uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main
22+
# with:
23+
# duckdb_version: 1.1.2
24+
# ci_tools_version: 1.1.2
25+
# extension_name: chsql
2526

2627
duckdb-stable-build:
2728
name: Build extension binaries

chsql/CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ set(TARGET_NAME chsql)
77
find_package(OpenSSL REQUIRED)
88
set(EXTENSION_NAME ${TARGET_NAME}_extension)
99
set(LOADABLE_EXTENSION_NAME ${TARGET_NAME}_loadable_extension)
10+
set(CHSQL_DUCKDB_VERSION ${DUCKDB_MAJOR_VERSION})
1011
project(${TARGET_NAME})
1112

1213
include_directories(

chsql/extension_config.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# This file is included by DuckDB's build system. It specifies which extension to load
2-
2+
set(CHSQL_DUCKDB_VERSION ${DUCKDB_MAJOR_VERSION})
33
include_directories(
44
./src/include
55
${CMAKE_CURRENT_SOURCE_DIR}/../duckdb/extension/parquet/include

chsql/src/include/chsql_parquet_types.h

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
#ifndef PARQUET_TYPES_H
66
#define PARQUET_TYPES_H
77

8+
89
#include "duckdb.hpp"
910
#include <parquet_types.h>
1011

chsql/src/parquet_ordered_scan.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ namespace duckdb {
3737
}
3838
columnMap.push_back(schema_column - reader->metadata->metadata->schema.begin() - 1);
3939
reader->reader_data.column_ids.push_back(
40-
MultiFileLocalColumnId(schema_column - reader->metadata->metadata->schema.begin() - 1));
40+
schema_column - reader->metadata->metadata->schema.begin() - 1);
4141
reader->reader_data.column_mapping.push_back(
42-
MultiFileGlobalIndex(it - returnCols.begin()));
42+
it - returnCols.begin());
4343
}
4444
auto order_by_column_it = find_if(
4545
reader->metadata->metadata->schema.begin(),
@@ -53,7 +53,7 @@ namespace duckdb {
5353
}
5454
void Scan(ClientContext& ctx) {
5555
chunk->Reset();
56-
reader->Scan(ctx, *scanState, *chunk);
56+
reader->Scan(*scanState, *chunk);
5757
if (!haveAbsentColumns || chunk->size() == 0) {
5858
return;
5959
}

0 commit comments

Comments
 (0)