Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined method `encode' for URI:Module #11

Open
tywhang opened this issue Oct 28, 2021 · 2 comments
Open

undefined method `encode' for URI:Module #11

tywhang opened this issue Oct 28, 2021 · 2 comments

Comments

@tywhang
Copy link

tywhang commented Oct 28, 2021

Thank you for writing/maintaining this gem.

This gem still uses URI.encode which has been removed in Ruby 3.
https://github.com/quark-zju/unshorten/blob/master/lib/unshorten.rb#L95

Will there be an update to address this?

Thank you
@gragtah gragtah mentioned this issue Jul 29, 2023
Merged
@gragtah
Copy link
Contributor

gragtah commented Jul 29, 2023

Opened PR here #12

@gragtah
Copy link
Contributor

gragtah commented Aug 2, 2023

Resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gragtah @tywhang