Make username/password optional and add driver property #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @radcortez, may I ask you to review this pull request :) ? |
radcortez
requested changes
Feb 7, 2024
jdbc/runtime/src/main/java/io/quarkiverse/config/jdbc/runtime/Repository.java
Outdated
Show resolved
Hide resolved
radcortez
approved these changes
Feb 8, 2024
|
Thank you for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we may not have both
usernameandpasswordset (for example when using Oracle Wallet, only the URL is set), I made them optional (otherwise it throws an exception if they are empty).I also added the
driverproperty that was missing. Not having it defined, for example for Oracle, will lead to runtime exceptions not finding the corresponding driver.I updated the documentation accordingly and took the opportunity to update the default value of
keyandvaluefields as they had a different default value from what was documented.