Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial code cleanup, Quarkus 3.15 LTS, fixed versions, Dev UI #57

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Initial code cleanup, Quarkus 3.15 LTS, fixed versions, Dev UI #57

merged 2 commits into from
Oct 2, 2024

Conversation

melloware
Copy link
Contributor

@melloware melloware commented Oct 1, 2024 •
edited
Loading

image

@melloware melloware requested a review from a team as a code owner October 1, 2024 18:59
gastaldi
gastaldi requested changes Oct 1, 2024
View reviewed changes
.github/project.yml Outdated Show resolved Hide resolved
@melloware melloware requested a review from gastaldi October 1, 2024 20:28
gastaldi
gastaldi reviewed Oct 1, 2024
View reviewed changes
.github/project.yml Outdated Show resolved Hide resolved
gastaldi
gastaldi approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@melloware melloware changed the title Initial code cleanup, Quarkus 3.8 LTS, fixed versions, Dev UI Initial code cleanup, Quarkus 3.15 LTS, fixed versions, Dev UI Oct 1, 2024
@melloware @gastaldi
Update deployment/src/main/java/io/quarkiverse/jasperreports/deployme…
52cb7aa 
…nt/devui/JasperReportsDevUIProcessor.java

Co-authored-by: George Gastaldi <[email protected]>
@melloware melloware merged commit 0bff191 into quarkiverse:main Oct 2, 2024
2 checks passed
@melloware melloware deleted the initial-pr branch October 2, 2024 11:55
@gastaldi
Copy link
Member

gastaldi commented Oct 2, 2024

@all-contributors add @melloware for code and maintenance

@allcontributors allcontributors bot mentioned this pull request Oct 2, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@gastaldi

I've put up a pull request to add @melloware! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with jasperreports custom fonts when generated uberjar Fonts
2 participants
@melloware @gastaldi