Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quarkus-playwright #499

Closed
ia3andy opened this issue Sep 6, 2023 · 12 comments · Fixed by #505
Closed

Use quarkus-playwright #499

ia3andy opened this issue Sep 6, 2023 · 12 comments · Fixed by #505
Assignees

Comments

@ia3andy
Copy link
Collaborator

ia3andy commented Sep 6, 2023

https://docs.quarkiverse.io/quarkus-playwright/dev/

  • We should keep quinoa-testing as it contains profiles, we can add quarkus-playwright as a dependency of quinoa-testing.
  • The doc needs to be updated
@ia3andy
Copy link
Collaborator Author

ia3andy commented Sep 6, 2023

@shivam-sharma7 this is a real coding and doc issue, go for it!

As this is important as a maintainer to be autonomous, please only ask questions if you are sure you can't answer it by yourself or from the internet.

Good luck :)

@shivam-sharma7
Copy link
Member

@ia3andy Here already some test present- https://github.com/quarkiverse/quarkus-quinoa/blob/main/integration-tests/src/test/java/io/quarkiverse/quinoa/it/QuinoaRootPathTest.java

would you like to clarify a bit more what are steps?

@ia3andy
Copy link
Collaborator Author

ia3andy commented Sep 7, 2023

@ia3andy Here already some test present- https://github.com/quarkiverse/quarkus-quinoa/blob/main/integration-tests/src/test/java/io/quarkiverse/quinoa/it/QuinoaRootPathTest.java

would you like to clarify a bit more what are steps?

Nop... you figure them out :)

@shivam-sharma7
Copy link
Member

shivam-sharma7 commented Sep 9, 2023

Is this extention published extensions on registry.quarkus.io?

see error

PS C:\Users\shivam sharma\Desktop\My Project\open-source\quarkus-quinoa\testing> mvn quarkus:add-extension -Dextensions="io.quarkiverse.playwright:quarkus-playwright"
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------< io.quarkiverse.quinoa:quarkus-quinoa-testing >------------
[INFO] Building Quarkus - Quinoa - Testing 999-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- quarkus-maven-plugin:3.3.0:add-extension (default-cli) @ quarkus-quinoa-testing ---
[INFO] [ERROR]  Nothing installed because keyword(s) 'io.quarkiverse.playwright:quarkus-playwright' were not matched in the catalog.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.405 s
[INFO] Finished at: 2023-09-09T19:09:32+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:3.3.0:add-extension (default-cli) on project quarkus-quinoa-testing: Unable to update the pom.xml file: Unable to add extensions -> [Help 1]

@shivam-sharma7
Copy link
Member

@melloware have any idea?

@melloware
Copy link
Contributor

You might have to add it to the Pom.xml manually.

@shivam-sharma7
Copy link
Member

@melloware Should we keep in pom.xml?

 <playright.version>1.37.0</playright.version>

because we are going to use quarkus-playwright my question is all imports from com.microsoft.playwright.BrowserContext would change in io.quarkiverse.playwright.BrowserContext?

@melloware
Copy link
Contributor

Yes I think you can remove that Playwright version as now it will come from the Quarkus Extension and be brought in transitively.

@ia3andy
Copy link
Collaborator Author

ia3andy commented Sep 12, 2023

@shivam-sharma7 where are you with this, this is an important update, I will make a release later today, if you can't make it by then I'll do it myself, it's a really easy change.

@shivam-sharma7
Copy link
Member

shivam-sharma7 commented Sep 12, 2023

@ia3andy I know, only we need to remove old one with this one and replace some imports. But why this is taking so much time to compile in my machine I have already mention some error-#474

@shivam-sharma7
Copy link
Member

shivam-sharma7 commented Sep 12, 2023

And it will take some time to resolve so you can do this.

@ia3andy
Copy link
Collaborator Author

ia3andy commented Sep 12, 2023

@shivam-sharma7 I will put you maintainer status on hold (you keep your contributor badge) until you figure all this out. It is important as a maintainer to be able to build the project locally, review PRs and add features.
PRs with just linting stuff or version update can be achieved by bots. I would advise you to look for good-first-issue around coding (not just docs) on the Quarkus eco-system and try to solve them by yourself with as little question and help as possible. When you believe you are ready to be a maintainer, I'll give you another issue to confirm and we can re-evaluate this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants