Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend auto-triage/mention feature to failing builds in e.g. quickstarts #451

Open
yrodiere opened this issue Jun 3, 2024 · 2 comments
Open

Comments

@yrodiere
Copy link
Member

yrodiere commented Jun 3, 2024

Right now when one make a change to Quarkus, they may inadvertently break the Quickstarts. It's generally easy to solve, but hard to spot, because it's hard to get properly notified about these failures.

For example I mainly work on Hibernate extensions on Quarkus. If I wanted to get notified when Hibernate quickstart builds start failing, my only option would be to subscribe to this issue, and then I'll be notified for every single quickstart failure, including those for the (many) extensions unrelated to Hibernate.

Solution proposal

In the bot, we already have code that:

  • in some place, analyzes a build (in particular test failures) and reports problems, grouped by module.
  • in another place, analyzes which directories a PR changed, then applies labels to that PRs and notifies the relevant people.

We could imagine that, on Quickstart build failures, the Quarkus bot, or an action, would analyze the build result, group propblems them by quickstart or relevant extension, then would provide a detailed report on the dedicated issue, and @mention the people responsible for these quickstarts or the relevant extensions.

@rsvoboda
Copy link
Member

rsvoboda commented Jun 3, 2024

We have Quickstarts compilation check in our Quarkus CI - https://github.com/quarkusio/quarkus/blob/main/.github/workflows/ci-actions-incremental.yml#L853

Tests were skipped to save CI capacity, maybe we can reconsider that decision. wdyt?

@yrodiere
Copy link
Member Author

yrodiere commented Jun 3, 2024

Tests were skipped to save CI capacity, maybe we can reconsider that decision. wdyt?

No opinion on resource usage, but it may not be strictly necessary. We'll need a way to detect compilation failures and assign them to the right people anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants