Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging guide should include "Metrics" section #1745

Open
jogerj opened this issue Jul 8, 2023 · 0 comments
Open

Logging guide should include "Metrics" section #1745

jogerj opened this issue Jul 8, 2023 · 0 comments

Comments

@jogerj
Copy link

jogerj commented Jul 8, 2023

Describe the bug
quarkus.log.metrics.enabled=true
TIL metrics for logging is disabled by default and can be overriden by a config value. Neither does Microprofile/Micrometer or logging guide pages referenced this.
The only reference I found to this config is in https://quarkus.io/guides/all-config

This wasn't just for logging, it seems other than the all-configs page, there isn't a page dedicated for which metrics are enabled by default.

I see two ways of resolving this:

  1. All guide pages where metrics are supported should have this included (e.g. see https://quarkus.io/guides/hibernate-orm#metrics)
  2. Micrometer/SmallRye page should include all configs possible for metrics supported.

Reason being if I want to implement metrics for a certain extension/plugin, the first thing I would look at would be either the guide related to the plugin, and/or the SmallRye/Micrometer page.

Which pages
https://quarkus.io/guides/logging
https://quarkus.io/guides/telemetry-micrometer
https://quarkus.io/guides/telemetry-micrometer-tutorial
https://quarkus.io/guides/smallrye-metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant