Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Quarkiverse extensions descriptions using parent description #1993

Open
xstefank opened this issue May 27, 2024 · 3 comments
Open

Some Quarkiverse extensions descriptions using parent description #1993

xstefank opened this issue May 27, 2024 · 3 comments

Comments

@xstefank
Copy link
Member

Describe the bug
In https://quarkus.io/extensions/ any Quarkiverse extension uses the same description that is inherited from the parent:

Parent POM for Quarkiverse projects that includes the default release and artifact publishing related configuration

I'm not sure if individual extensions override this, but if they don't we should ask them to.

Which pages
https://quarkus.io/extensions/

I'm not sure where I should raise this, so point me to the correct place if this is not it, please.

@holly-cummins
Copy link
Contributor

@xstefank, do you have a screenshot? It's expected that quarkiverse extensions which don't provide an extension in the pom inherit the parent description (which is annoying), but last time I checked, most extensions had unique descriptions. If you're seeing big swathes of identical descriptions, that's unexpected.

The fact that we show stupid-looking parent descriptions is a known problem (see quarkusio/quarkus#31634). We also discussed this at https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/quarkiverse.20parents/near/375241089.

Options to fix it include:

@xstefank
Copy link
Member Author

@holly-cummins thanks for the info. If I just search for "quarkiverse" I can see this
2024-05-29-1716987683_1519x853

Personally, I think we should enforce it. It's not so much work and it would look way better on the site.

@holly-cummins
Copy link
Contributor

Thanks, @xstefank. I'm relieved we haven't had a huge regression :)

I'll update the issue title to reflect that.

I think enforcing it may be ok, but we need to make sure to do it early enough in the process that it doesn't contribute to what can already be a rather long "I'd like to publish," "ah, but you did something wrong!", "ok, fixed that, I'd like to publish," "ah, but you did another thing wrong!" feedback cycle. It also can't be so early in the cycle that people who've just created an extension from the template get harassed to fill in all sorts of information. In the worse case, that makes them fill in dummy data, so it doesn't help.

We should also be aware that even if we implement enforcing, there will be some extensions that have the parent description. The Jdbi extension has an unfixed issue open against it for the missing description. Some of the other extensions which are missing descriptions haven't had a release for a year or two, so blocking publication won't actually affect them.

@xstefank xstefank changed the title All Quarkiverse extensions descriptions are the same Some Quarkiverse extensions descriptions using parent description May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants