Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the quarkus group with 5 updates #345

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2024

Bumps the quarkus group with 5 updates:

Package From To
io.quarkus:quarkus-bom 3.15.1 3.16.0
io.quarkus:quarkus-ide-config 3.15.1 3.16.0
io.quarkus:quarkus-maven-plugin 3.15.1 3.16.0
io.quarkiverse.jgit:quarkus-jgit 3.3.0 3.3.1
io.quarkiverse.playwright:quarkus-playwright 1.0.0 1.1.0

Updates io.quarkus:quarkus-bom from 3.15.1 to 3.16.0

Release notes

Sourced from io.quarkus:quarkus-bom's releases.

3.16.0.CR1

Major changes

  • #38239 - Logging OpenTelemetry extension
  • #41264 - LGTM Quarkus Dashboard
  • #41866 - Add quarkus-oidc-client-registration extension
  • #42642 - Support record parameter containers
  • #42749 - Add new AuthorizationPolicy annotation to bind named HttpSecurityPolicy to a Jakarta REST endpoints
  • #42879 - Add OIDC Client SPI
  • #42935 - Support for two or more authentications for a single request
  • #43005 - Drop the compatibility layer for the Big Reactive Rename
  • #43241 - Support @PermissionsAllowed defined on meta-annotation
  • #43283 - Introduce OidcResponseFilter
  • #43331 - Introduce per invocation override of REST Client's base URL
  • #43402 - Auto log for dev services in containers
  • #43441 - Add HTTP Access Log to Dev UI
  • #43609 - Support Keycloak Dev Service when OIDC client is used without OIDC extension

Complete changelog

  • #10435 - Misconfigured TCCL for @TestFactory dynamic tests breaks RestAssured since Quarkus 1.5.0
  • #19686 - Support constructor injection for RESTEasy Reactive multipart bodies
  • #22824 - Add jitter to scheduler
  • #23559 - Buildpack for Quarkus/Quarkus Native
  • #23883 - When using buildpack without docker running gets a meaningless exception
  • #24378 - KafkaDevServicesContinuousTestingWorkingAppPropsTestCase / PriceResourceET do not indicate recovery is tested, logs with test errors
  • #25496 - When using reactive restclient in 2.8.2.Final with Response, getEntity() returns null even if there is a body in Response
  • #27326 - MongoDB panache generates invalid update documents when updating a list or array with HQL
  • #29191 - Subscribing to CompletionStage returned by Event.fireAsync doesn't seem to work correctly
  • #30712 - Support OpenTelemetry Log signal
  • #31328 - Support for inclusive authentication
  • #32143 - OIDC document shoud update
  • #32159 - Redis client with AWS Elasticache
  • #33018 - ServletContextInitializer IT test
  • #33665 - Clarify the behavior of InstanceHandle.close()
  • #33666 - Clarify class-level interceptor binding inheritance
  • #35871 - Jackson @JsonView deserialization support for request bodies
  • #36227 - Accept-Language header not parsed correctly for language subtags, variants, extension and private subtags
  • #36228 - Use java.util.Locale to parse the languages from the Accept-Language header
  • #36336 - @CacheResult on legacy @RegisterRestClient throws CCE on 3.4.2
  • #37243 - Enhance keycloak-admin-client extension to support TLS trust and key stores
  • #37777 - Building Quarkus with Buildpacks uses Liberica as JDK
  • #38228 - Better support for APT in dev mode: Gradle part
  • #38239 - Logging OpenTelemetry extension
  • #38250 - Support for OIDC Dynamic Client Registration
  • #38814 - Memory usage increased between Quarkus 3.6 and 3.7
  • #39663 - Security - Ability to create custom permission annotation
  • #39950 - File and FileUpload result in different OpenAPI spec, upload button missing
  • #40007 - Add ability to hide rest endpoints from OpenAPI schema / Swagger
  • #40829 - dynamic default page can't handle I add a index.html file

... (truncated)

Commits
  • 06af163 [RELEASE] - Bump version to 3.16.0
  • 9c118bc Merge pull request #44036 from gsmet/3.16.0-backports-2
  • cf6b2fe renaming to library
  • 1c9483d avoiding forcing resolution when configuring QuarkusApplicationModelTask
  • 5c11e57 Fix for issue 42549 - replaces oidc authentication for github screenshots wit...
  • 3b0b8d8 Docs typo fixes - specificed, agrument
  • 2e764f8 Add RESTEasy Multipart capability
  • 60b802a Work around failure of maturity model PR to merge
  • 9b14a31 Skeleton extensions FAQ
  • 20baabe Merge pull request #44002 from gsmet/3.16.0-backports-1
  • Additional commits viewable in compare view

Updates io.quarkus:quarkus-ide-config from 3.15.1 to 3.16.0

Release notes

Sourced from io.quarkus:quarkus-ide-config's releases.

3.16.0.CR1

Major changes

  • #38239 - Logging OpenTelemetry extension
  • #41264 - LGTM Quarkus Dashboard
  • #41866 - Add quarkus-oidc-client-registration extension
  • #42642 - Support record parameter containers
  • #42749 - Add new AuthorizationPolicy annotation to bind named HttpSecurityPolicy to a Jakarta REST endpoints
  • #42879 - Add OIDC Client SPI
  • #42935 - Support for two or more authentications for a single request
  • #43005 - Drop the compatibility layer for the Big Reactive Rename
  • #43241 - Support @PermissionsAllowed defined on meta-annotation
  • #43283 - Introduce OidcResponseFilter
  • #43331 - Introduce per invocation override of REST Client's base URL
  • #43402 - Auto log for dev services in containers
  • #43441 - Add HTTP Access Log to Dev UI
  • #43609 - Support Keycloak Dev Service when OIDC client is used without OIDC extension

Complete changelog

  • #10435 - Misconfigured TCCL for @TestFactory dynamic tests breaks RestAssured since Quarkus 1.5.0
  • #19686 - Support constructor injection for RESTEasy Reactive multipart bodies
  • #22824 - Add jitter to scheduler
  • #23559 - Buildpack for Quarkus/Quarkus Native
  • #23883 - When using buildpack without docker running gets a meaningless exception
  • #24378 - KafkaDevServicesContinuousTestingWorkingAppPropsTestCase / PriceResourceET do not indicate recovery is tested, logs with test errors
  • #25496 - When using reactive restclient in 2.8.2.Final with Response, getEntity() returns null even if there is a body in Response
  • #27326 - MongoDB panache generates invalid update documents when updating a list or array with HQL
  • #29191 - Subscribing to CompletionStage returned by Event.fireAsync doesn't seem to work correctly
  • #30712 - Support OpenTelemetry Log signal
  • #31328 - Support for inclusive authentication
  • #32143 - OIDC document shoud update
  • #32159 - Redis client with AWS Elasticache
  • #33018 - ServletContextInitializer IT test
  • #33665 - Clarify the behavior of InstanceHandle.close()
  • #33666 - Clarify class-level interceptor binding inheritance
  • #35871 - Jackson @JsonView deserialization support for request bodies
  • #36227 - Accept-Language header not parsed correctly for language subtags, variants, extension and private subtags
  • #36228 - Use java.util.Locale to parse the languages from the Accept-Language header
  • #36336 - @CacheResult on legacy @RegisterRestClient throws CCE on 3.4.2
  • #37243 - Enhance keycloak-admin-client extension to support TLS trust and key stores
  • #37777 - Building Quarkus with Buildpacks uses Liberica as JDK
  • #38228 - Better support for APT in dev mode: Gradle part
  • #38239 - Logging OpenTelemetry extension
  • #38250 - Support for OIDC Dynamic Client Registration
  • #38814 - Memory usage increased between Quarkus 3.6 and 3.7
  • #39663 - Security - Ability to create custom permission annotation
  • #39950 - File and FileUpload result in different OpenAPI spec, upload button missing
  • #40007 - Add ability to hide rest endpoints from OpenAPI schema / Swagger
  • #40829 - dynamic default page can't handle I add a index.html file

... (truncated)

Commits
  • 06af163 [RELEASE] - Bump version to 3.16.0
  • 9c118bc Merge pull request #44036 from gsmet/3.16.0-backports-2
  • cf6b2fe renaming to library
  • 1c9483d avoiding forcing resolution when configuring QuarkusApplicationModelTask
  • 5c11e57 Fix for issue 42549 - replaces oidc authentication for github screenshots wit...
  • 3b0b8d8 Docs typo fixes - specificed, agrument
  • 2e764f8 Add RESTEasy Multipart capability
  • 60b802a Work around failure of maturity model PR to merge
  • 9b14a31 Skeleton extensions FAQ
  • 20baabe Merge pull request #44002 from gsmet/3.16.0-backports-1
  • Additional commits viewable in compare view

Updates io.quarkus:quarkus-maven-plugin from 3.15.1 to 3.16.0

Updates io.quarkiverse.jgit:quarkus-jgit from 3.3.0 to 3.3.1

Release notes

Sourced from io.quarkiverse.jgit:quarkus-jgit's releases.

3.3.1

What's Changed

Full Changelog: quarkiverse/quarkus-jgit@3.3.0...3.3.1

Commits
  • e8f7673 [maven-release-plugin] prepare release 3.3.1
  • b2b8a30 Update the latest release version 3.3.1 in documentation
  • 57026a2 Release 3.3.1 (#157)
  • 362aebe Allow repository creation in the Gitea DevService (#156)
  • 360c730 Reuse images from .github (#155)
  • 944c850 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Updates io.quarkiverse.playwright:quarkus-playwright from 1.0.0 to 1.1.0

Release notes

Sourced from io.quarkiverse.playwright:quarkus-playwright's releases.

1.1.0

What's Changed

New Contributors

Full Changelog: quarkiverse/quarkus-playwright@1.0.0...1.1.0

Commits
  • 188dc55 [maven-release-plugin] prepare release 1.1.0
  • 49b1797 Update the latest release version 1.1.0 in documentation
  • 65bfa8e 1.1.0 (#94)
  • c8334c6 docs: add rmanibus as a contributor for test (#93)
  • 186ee00 docs: add maxsonaraujo as a contributor for ideas (#92)
  • 022f23d docs: add edeandrea as a contributor for ideas (#91)
  • e39cae7 Update README.md
  • f77bd33 IntelliJ logo
  • a04e401 Enhanced Switch Statement
  • 4450ce4 docs: add thomaswiradikusuma as a contributor for ideas (#90)
  • Additional commits viewable in compare view

Updates io.quarkus:quarkus-ide-config from 3.15.1 to 3.16.0

Release notes

Sourced from io.quarkus:quarkus-ide-config's releases.

3.16.0.CR1

Major changes

  • #38239 - Logging OpenTelemetry extension
  • #41264 - LGTM Quarkus Dashboard
  • #41866 - Add quarkus-oidc-client-registration extension
  • #42642 - Support record parameter containers
  • #42749 - Add new AuthorizationPolicy annotation to bind named HttpSecurityPolicy to a Jakarta REST endpoints
  • #42879 - Add OIDC Client SPI
  • #42935 - Support for two or more authentications for a single request
  • #43005 - Drop the compatibility layer for the Big Reactive Rename
  • #43241 - Support @PermissionsAllowed defined on meta-annotation
  • #43283 - Introduce OidcResponseFilter
  • #43331 - Introduce per invocation override of REST Client's base URL
  • #43402 - Auto log for dev services in containers
  • #43441 - Add HTTP Access Log to Dev UI
  • #43609 - Support Keycloak Dev Service when OIDC client is used without OIDC extension

Complete changelog

  • #10435 - Misconfigured TCCL for @TestFactory dynamic tests breaks RestAssured since Quarkus 1.5.0
  • #19686 - Support constructor injection for RESTEasy Reactive multipart bodies
  • #22824 - Add jitter to scheduler
  • #23559 - Buildpack for Quarkus/Quarkus Native
  • #23883 - When using buildpack without docker running gets a meaningless exception
  • #24378 - KafkaDevServicesContinuousTestingWorkingAppPropsTestCase / PriceResourceET do not indicate recovery is tested, logs with test errors
  • #25496 - When using reactive restclient in 2.8.2.Final with Response, getEntity() returns null even if there is a body in Response
  • #27326 - MongoDB panache generates invalid update documents when updating a list or array with HQL
  • #29191 - Subscribing to CompletionStage returned by Event.fireAsync doesn't seem to work correctly
  • #30712 - Support OpenTelemetry Log signal
  • #31328 - Support for inclusive authentication
  • #32143 - OIDC document shoud update
  • #32159 - Redis client with AWS Elasticache
  • #33018 - ServletContextInitializer IT test
  • #33665 - Clarify the behavior of InstanceHandle.close()
  • #33666 - Clarify class-level interceptor binding inheritance
  • #35871 - Jackson @JsonView deserialization support for request bodies
  • #36227 - Accept-Language header not parsed correctly for language subtags, variants, extension and private subtags
  • #36228 - Use java.util.Locale to parse the languages from the Accept-Language header
  • #36336 - @CacheResult on legacy @RegisterRestClient throws CCE on 3.4.2
  • #37243 - Enhance keycloak-admin-client extension to support TLS trust and key stores
  • #37777 - Building Quarkus with Buildpacks uses Liberica as JDK
  • #38228 - Better support for APT in dev mode: Gradle part
  • #38239 - Logging OpenTelemetry extension
  • #38250 - Support for OIDC Dynamic Client Registration
  • #38814 - Memory usage increased between Quarkus 3.6 and 3.7
  • #39663 - Security - Ability to create custom permission annotation
  • #39950 - File and FileUpload result in different OpenAPI spec, upload button missing
  • #40007 - Add ability to hide rest endpoints from OpenAPI schema / Swagger
  • #40829 - dynamic default page can't handle I add a index.html file

... (truncated)

Commits
  • 06af163 [RELEASE] - Bump version to 3.16.0
  • 9c118bc Merge pull request #44036 from gsmet/3.16.0-backports-2
  • cf6b2fe renaming to library
  • 1c9483d avoiding forcing resolution when configuring QuarkusApplicationModelTask
  • 5c11e57 Fix for issue 42549 - replaces oidc authentication for github screenshots wit...
  • 3b0b8d8 Docs typo fixes - specificed, agrument
  • 2e764f8 Add RESTEasy Multipart capability
  • 60b802a Work around failure of maturity model PR to merge
  • 9b14a31 Skeleton extensions FAQ
  • 20baabe Merge pull request #44002 from gsmet/3.16.0-backports-1
  • Additional commits viewable in compare view

Updates io.quarkus:quarkus-maven-plugin from 3.15.1 to 3.16.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 28, 2024
@dependabot dependabot bot force-pushed the dependabot/maven/quarkus-c03cfa1d3a branch from 39a5881 to 8d60cd2 Compare October 28, 2024 07:03
@marko-bekhta
Copy link
Collaborator

@dependabot rebase

Bumps the quarkus group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [io.quarkus:quarkus-bom](https://github.com/quarkusio/quarkus) | `3.15.1` | `3.16.0` |
| [io.quarkus:quarkus-ide-config](https://github.com/quarkusio/quarkus) | `3.15.1` | `3.16.0` |
| io.quarkus:quarkus-maven-plugin | `3.15.1` | `3.16.0` |
| [io.quarkiverse.jgit:quarkus-jgit](https://github.com/quarkiverse/quarkus-jgit) | `3.3.0` | `3.3.1` |
| [io.quarkiverse.playwright:quarkus-playwright](https://github.com/quarkiverse/quarkus-playwright) | `1.0.0` | `1.1.0` |


Updates `io.quarkus:quarkus-bom` from 3.15.1 to 3.16.0
- [Release notes](https://github.com/quarkusio/quarkus/releases)
- [Commits](quarkusio/quarkus@3.15.1...3.16.0)

Updates `io.quarkus:quarkus-ide-config` from 3.15.1 to 3.16.0
- [Release notes](https://github.com/quarkusio/quarkus/releases)
- [Commits](quarkusio/quarkus@3.15.1...3.16.0)

Updates `io.quarkus:quarkus-maven-plugin` from 3.15.1 to 3.16.0

Updates `io.quarkiverse.jgit:quarkus-jgit` from 3.3.0 to 3.3.1
- [Release notes](https://github.com/quarkiverse/quarkus-jgit/releases)
- [Commits](quarkiverse/quarkus-jgit@3.3.0...3.3.1)

Updates `io.quarkiverse.playwright:quarkus-playwright` from 1.0.0 to 1.1.0
- [Release notes](https://github.com/quarkiverse/quarkus-playwright/releases)
- [Commits](quarkiverse/quarkus-playwright@1.0.0...1.1.0)

Updates `io.quarkus:quarkus-ide-config` from 3.15.1 to 3.16.0
- [Release notes](https://github.com/quarkusio/quarkus/releases)
- [Commits](quarkusio/quarkus@3.15.1...3.16.0)

Updates `io.quarkus:quarkus-maven-plugin` from 3.15.1 to 3.16.0

---
updated-dependencies:
- dependency-name: io.quarkus:quarkus-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: quarkus
- dependency-name: io.quarkus:quarkus-ide-config
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: quarkus
- dependency-name: io.quarkus:quarkus-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: quarkus
- dependency-name: io.quarkiverse.jgit:quarkus-jgit
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: quarkus
- dependency-name: io.quarkiverse.playwright:quarkus-playwright
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: quarkus
- dependency-name: io.quarkus:quarkus-ide-config
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: quarkus
- dependency-name: io.quarkus:quarkus-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: quarkus
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/quarkus-c03cfa1d3a branch from 8d60cd2 to f32ce44 Compare October 28, 2024 07:15
@marko-bekhta
Copy link
Collaborator

With the new Quarkus update I was getting all kinds of strange test failures including:

Caused by: org.hibernate.search.mapper.pojo.common.annotation.impl.SearchProcessingWithContextException: Failed to read 'GitInputProvider{path='docs/version/3.2/guides/all-config.html'}' for indexing: Out of memory loading unknown object
Context: path '.htmlFullContentProvider'
	at org.hibernate.search.mapper.pojo.processing.impl.PojoIndexingProcessorPropertyNode.process(PojoIndexingProcessorPropertyNode.java:68)
	at org.hibernate.search.mapper.pojo.processing.impl.PojoIndexingProcessorMultiNode.process(PojoIndexingProcessorMultiNode.java:43)
	at org.hibernate.search.mapper.pojo.processing.impl.PojoIndexingProcessorOriginalTypeNode.process(PojoIndexingProcessorOriginalTypeNode.java:61)
	at org.hibernate.search.mapper.pojo.work.impl.PojoDocumentContributor.contribute(PojoDocumentContributor.java:53)
	... 19 more
Caused by: java.lang.IllegalStateException: Failed to read 'GitInputProvider{path='docs/version/3.2/guides/all-config.html'}' for indexing: Out of memory loading unknown object
	at io.quarkus.search.app.hibernate.InputProviderHtmlBodyTextBridge.toIndexedValue(InputProviderHtmlBodyTextBridge.java:42)
	at io.quarkus.search.app.hibernate.InputProviderHtmlBodyTextBridge.toIndexedValue(InputProviderHtmlBodyTextBridge.java:16)
	at io.quarkus.search.app.hibernate.I18nDataBinder$Bridge.toIndexedValue(I18nDataBinder.java:51)
	at io.quarkus.search.app.hibernate.I18nDataBinder$Bridge.toIndexedValue(I18nDataBinder.java:33)
	at org.hibernate.search.mapper.pojo.processing.impl.PojoIndexingProcessorValueBridgeNode.process(PojoIndexingProcessorValueBridgeNode.java:49)
	at org.hibernate.search.mapper.pojo.processing.impl.PojoIndexingProcessorMultiNode.process(PojoIndexingProcessorMultiNode.java:43)
	at org.hibernate.search.mapper.pojo.processing.impl.PojoIndexingProcessorPropertyNode.process(PojoIndexingProcessorPropertyNode.java:61)
	... 22 more
Caused by: org.eclipse.jgit.errors.LargeObjectException$OutOfMemory: Out of memory loading unknown object
	at org.eclipse.jgit.internal.storage.file.Pack.load(Pack.java:923)
	at org.eclipse.jgit.internal.storage.file.Pack.get(Pack.java:290)
	at org.eclipse.jgit.internal.storage.file.PackDirectory.open(PackDirectory.java:228)
	at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedObject(ObjectDirectory.java:412)
	at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedFromSelfOrAlternate(ObjectDirectory.java:375)
	at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openObjectWithoutRestoring(ObjectDirectory.java:365)
	at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openObject(ObjectDirectory.java:350)
	at org.eclipse.jgit.internal.storage.file.WindowCursor.open(WindowCursor.java:133)
	at org.eclipse.jgit.lib.ObjectDatabase.open(ObjectDatabase.java:181)
	at org.eclipse.jgit.lib.ObjectDatabase.open(ObjectDatabase.java:151)
	at org.eclipse.jgit.lib.Repository.open(Repository.java:327)
	at io.quarkus.search.app.util.GitUtils.file(GitUtils.java:65)
	at io.quarkus.search.app.util.GitInputProvider.open(GitInputProvider.java:24)
	at io.quarkus.search.app.hibernate.InputProviderHtmlBodyTextBridge.toIndexedValue(InputProviderHtmlBodyTextBridge.java:19)
	... 28 more
Caused by: java.lang.OutOfMemoryError: Java heap space
	at org.eclipse.jgit.internal.storage.file.Pack.load(Pack.java:920)
	at org.eclipse.jgit.internal.storage.file.Pack.get(Pack.java:290)
	at org.eclipse.jgit.internal.storage.file.PackDirectory.open(PackDirectory.java:228)
	at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedObject(ObjectDirectory.java:412)
	at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedFromSelfOrAlternate(ObjectDirectory.java:375)
	at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openObjectWithoutRestoring(ObjectDirectory.java:365)
	at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openObject(ObjectDirectory.java:350)
	at org.eclipse.jgit.internal.storage.file.WindowCursor.open(WindowCursor.java:133)
	at org.eclipse.jgit.lib.ObjectDatabase.open(ObjectDatabase.java:181)
	at org.eclipse.jgit.lib.ObjectDatabase.open(ObjectDatabase.java:151)
	at org.eclipse.jgit.lib.Repository.open(Repository.java:327)
	at io.quarkus.search.app.util.GitUtils.file(GitUtils.java:65)

I remember seeing the "un-deprecating" of the QuarkusTestResource, but I thought it was a while ago ...

@marko-bekhta marko-bekhta requested a review from yrodiere October 28, 2024 09:25
@yrodiere
Copy link
Member

yrodiere commented Oct 28, 2024

I remember seeing the "un-deprecating" of the QuarkusTestResource, but I thought it was a while ago ...

I think your problems are caused by this change in 3.16: https://github.com/quarkusio/quarkus/pull/42852/files#diff-b95cabb296ef9595232c575b9fdd805b10784d03b9b25882ecfc23908b38f229R16-R18

So TestResourceScope.MATCHING_RESOURCES is causing OOM, but RESTRICTED_TO_CLASS is not. Which is weird, because MATCHING_RESOURCES, from what I understand, would reuse resources and thus reduce the risk of OOM if there's a memory leak.

It'd be interesting to know why, but we don't need to wait for the result of that investigation before we merge, so +1 for your changes.

Regardless... @geoand do I understand correctly that only lifecycle manager class names are taken into account when comparing resources needed by tests? That seems dangerous considering test resource managers can be parameterized per-class like this? Shouldn't the comparison also take into account the relevant annotation when the manager implements QuarkusTestResourceConfigurableLifecycleManager?

@yrodiere yrodiere merged commit 41e3b9f into main Oct 28, 2024
1 check passed
@dependabot dependabot bot deleted the dependabot/maven/quarkus-c03cfa1d3a branch October 28, 2024 10:15
@geoand
Copy link

geoand commented Oct 28, 2024

I would need to check as I don't remember

@yrodiere
Copy link
Member

I would need to check as I don't remember

I created quarkusio/quarkus#44129 , let's address in due time -- or just close if I'm wrong.

@geoand
Copy link

geoand commented Oct 28, 2024

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants