Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock miniconf-mqtt python utilities to a tag #661

Closed
ryan-summers opened this issue Dec 14, 2022 · 4 comments
Closed

Lock miniconf-mqtt python utilities to a tag #661

ryan-summers opened this issue Dec 14, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@ryan-summers
Copy link
Member

Given that miniconf is undergoing heavy changes and development right now, the current main branch is incompatible with released miniconf versions. We should use a tag reference for the Python client similar to cargo.toml

@jordens
Copy link
Member

jordens commented Dec 14, 2022

Let's just release the miniconf client to pypi properly and install a specific version from there.

@jordens
Copy link
Member

jordens commented Dec 20, 2022

Done here in fdaa6d4 but should just be a miniconf pypi release.

@ryan-summers
Copy link
Member Author

Miniconf release is tracked in quartiq/miniconf#136, but I'm not entirely sure it's even worth regular releases of Miniconf on Pypi. @jordens An alternative approach is to just keep the python dependency locked to the tag of the Miniconf version we're using and just avoiding PyPi.

I have nothing against releasing to PyPi, but it just feels like one more thing we need to keep track of, which is somewhat annoying. Maybe CI could automate the release process for us though

@jordens
Copy link
Member

jordens commented Apr 15, 2024

Agreed. Explicit dependency is fine.

@jordens jordens closed this as completed Apr 15, 2024
jordens added a commit that referenced this issue Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants