diff --git a/app/apptesting/test_suite.go b/app/apptesting/test_suite.go index f4deed4f6..d2179101a 100644 --- a/app/apptesting/test_suite.go +++ b/app/apptesting/test_suite.go @@ -353,7 +353,7 @@ func (s *KeeperTestHelper) BeginNewBlockWithProposer(proposer sdk.ValAddress) { valAddr := valConsAddr - //TODO: when we add any logic executed over some epochs use below logic + //Note : when we add any logic executed over some epochs use below logic //epochIdentifier := s.App.EpochsKeeper.GetEpochInfo(s.Ctx,) //epoch := s.App.EpochsKeeper.GetEpochInfo(s.Ctx, epochIdentifier) newBlockTime := s.Ctx.BlockTime().Add(5 * time.Second) diff --git a/app/keepers/keepers.go b/app/keepers/keepers.go index d4e3d1b8c..b3e1f9e30 100644 --- a/app/keepers/keepers.go +++ b/app/keepers/keepers.go @@ -489,9 +489,6 @@ func (appKeepers *AppKeepers) InitNormalKeepers( // set token factory contract keeper appKeepers.TfKeeper.SetContractKeeper(appKeepers.ContractKeeper) - // TODO - SDK 50 - // callback := owasm.NewCallbackPlugin(appKeepers.WasmKeeper, appKeepers.QTransferKeeper.GetQTransferAcc()) - tmpBankBaseKeeper := appKeepers.BankKeeper.(bankkeeper.BaseKeeper) wasmOpts = append(tfbindings.RegisterCustomPlugins(&tmpBankBaseKeeper, &appKeepers.TfKeeper), wasmOpts...) diff --git a/app/params/params.go b/app/params/params.go index 7a884a0b4..012570ffe 100644 --- a/app/params/params.go +++ b/app/params/params.go @@ -56,7 +56,6 @@ func SetAddressPrefixes() { return errorsmod.Wrapf(sdkerrors.ErrUnknownAddress, "address max length is %d, got %d, %x", address.MaxAddrLen, len(bytes), bytes) } - // TODO: Do we want to allow addresses of lengths other than 20 and 32 bytes? if len(bytes) != 20 && len(bytes) != 32 { return errorsmod.Wrapf(sdkerrors.ErrUnknownAddress, "address length must be 20 or 32 bytes, got %d, %x", len(bytes), bytes) } diff --git a/app/upgrades/types.go b/app/upgrades/types.go index c7528d56c..71e1d2d25 100644 --- a/app/upgrades/types.go +++ b/app/upgrades/types.go @@ -16,14 +16,6 @@ type BaseAppParamManager interface { StoreConsensusParams(ctx sdk.Context, cp tmproto.ConsensusParams) error } -const ( - ProdChainID = "quasar-1" - TestChainID = "quasar-test-1" - - // upgrade name consts: vMMmmppUpgradeName (M=Major, m=minor, p=patch). - V030000UpgradeName = "v3.0.0" -) - // Upgrade defines a struct containing necessary fields that a SoftwareUpgradeProposal // must have written, in order for the state migration to go smoothly. // An upgrade must implement this struct, and then set it in the app.go. @@ -42,12 +34,3 @@ type Upgrade struct { // Store upgrades, should be used for any new modules introduced, new modules deleted, or store names renamed. StoreUpgrades storetypes.StoreUpgrades } - -// todo before release -// func isMainnet(ctx sdk.Context) bool { -// return ctx.ChainID() == ProdChainID -//} -// -//func isTestnet(ctx sdk.Context) bool { -// return ctx.ChainID() == TestChainID -//} diff --git a/cmd/quasard/cmd/root.go b/cmd/quasard/cmd/root.go index 3d1316d44..8703eaf5a 100644 --- a/cmd/quasard/cmd/root.go +++ b/cmd/quasard/cmd/root.go @@ -158,12 +158,10 @@ func enrichAutoCliOpts(autoCliOpts autocli.AppOptions, clientCtx client.Context) func initCometConfig() *tmcfg.Config { cfg := tmcfg.DefaultConfig() - // TODO - SDK50 - Can get some ref for the default values from quicksilver // https://github.com/quicksilver-zone/quicksilver/blob/update/sdk47/cmd/quicksilverd/root.go#L137 - // these values put a higher strain on node memory - // cfg.P2P.MaxNumInboundPeers = 100 - // cfg.P2P.MaxNumOutboundPeers = 40 + cfg.P2P.MaxNumInboundPeers = 40 + cfg.P2P.MaxNumOutboundPeers = 10 return cfg } @@ -185,7 +183,6 @@ func initRootCmd( rootCmd.AddCommand( genutilcli.InitCmd(basicManager, app.DefaultNodeHome), tmcli.NewCompletionCmd(rootCmd, true), - // todo add testnet commands confixcmd.ConfigCommand(), pruning.Cmd(ac.newApp, app.DefaultNodeHome), snapshot.Cmd(ac.newApp), @@ -203,7 +200,7 @@ func initRootCmd( genutilcli.ValidateGenesisCmd(basicManager), AddGenesisAccountCmd(app.DefaultNodeHome), debugCmd, - // config.Cmd(), TODO - SDK 50. Config support to be added. https://github.com/neutron-org/neutron/blob/feat/sdk-50/cmd/neutrond/config.go + // config.Cmd(), TODO Slinky : Config support to be added. https://github.com/neutron-org/neutron/blob/feat/sdk-50/cmd/neutrond/config.go ) // add server commands