Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing in actions icon for menu #24

Open
danrabyhive opened this issue Feb 17, 2022 · 2 comments
Open

Allow passing in actions icon for menu #24

danrabyhive opened this issue Feb 17, 2022 · 2 comments
Labels
Milestone

Comments

@danrabyhive
Copy link

danrabyhive commented Feb 17, 2022

Is your feature request related to a problem? Please describe.
When using a icon font other than material, it is impossible to fix the more actions button.

Describe the solution you'd like
Add property to allow this icon to be set.

Describe alternatives you've considered
Right now I can't think of a way to fix this without forking and forcing the new version in the build.

Edit: I'm going to use a custom header.

Additional context
The icon is hard-coded in the render function:

__renderMoreButton (h, menuData) {
if (this.noMenu === true) {
return ''
}
return h(QBtn, {
staticClass: 'q-window__titlebar--actions',
props: {
flat: true,
round: true,
dense: true,
icon: 'more_vert'
}
}, [
this.__renderMoreMenu(h, menuData)
])
},

@hawkeye64
Copy link
Member

Good catch. I'll look into a fix for this on the weekend.

@nucle
Copy link
Collaborator

nucle commented Mar 12, 2022

I will also implement this feature in the new version of qwindow 2

@nucle nucle added the feature label Mar 13, 2022
@nucle nucle added this to the qwindow v2 milestone Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants