Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ui/QDate): add QDate tests #16919

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

n05la3
Copy link
Contributor

@n05la3 n05la3 commented Feb 22, 2024

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Copy link

github-actions bot commented Feb 22, 2024

UI Tests Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
2 files    0 ❌
2 errors

For more details on these parsing errors, see this check.

Results for commit e310a01.

♻️ This comment has been updated with latest results.

@IlCallo IlCallo force-pushed the test/add-q-date-tests branch from 7d6ce4c to 02d9a8a Compare February 23, 2024 13:22
@n05la3 n05la3 marked this pull request as ready for review February 23, 2024 13:23
@IlCallo IlCallo self-assigned this Feb 23, 2024
@n05la3 n05la3 force-pushed the test/add-q-date-tests branch from 02d9a8a to e310a01 Compare February 28, 2024 07:52
@n05la3
Copy link
Contributor Author

n05la3 commented Feb 28, 2024

I have added tests for 'use-datetime' which I missed initially. I also rebased on dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants