Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.21.1 Fabric and NeoForge #26

Merged
merged 9 commits into from
Oct 15, 2024
Merged

1.21.1 Fabric and NeoForge #26

merged 9 commits into from
Oct 15, 2024

Conversation

MerchantPug
Copy link
Contributor

@MerchantPug MerchantPug commented Oct 15, 2024 •
edited
Loading

  • Abstracted over 1.21 specifics in ApathyPlusMinecraft for each version.
  • Now using ResourceKeys for MobEffect abstraction as 1.21 primarily uses holders for them.
  • Fabric is pretty much the same as before.
  • NeoForge now uses Fabric Mixin, so we can get rid of the crusty mixin from it.
  • IExtensionPoint.DisplayTest has been removed from NeoForge. There is no replacement for it.

@MerchantPug MerchantPug marked this pull request as draft October 15, 2024 19:58
@MerchantPug MerchantPug marked this pull request as ready for review October 15, 2024 20:01
quat1024
quat1024 reviewed Oct 15, 2024
View reviewed changes
Copy link
Owner

@quat1024 quat1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much💖

@quat1024 quat1024 merged commit ef1e399 into quat1024:trunk Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quat1024 quat1024 quat1024 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MerchantPug @quat1024