Merge pull request #225 from jrha/max_threads

hardware: Fix bugs in max threads calculation and validate schema property
quattor · Sep 16, 2024 · d51718b · d51718b
2 parents 13994d0 + b682732
commit d51718b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/quattor/functions/hardware.pan b/quattor/functions/hardware.pan
@@ -41,15 +41,11 @@ function get_num_of_cores_max_threads = {
             'threads', 0,
         );
         foreach (i; cpu; hw_config['cpu']) {
+            result['cores'] = result['cores'] + cpu['cores'];
             if (is_defined(cpu['max_threads'])) {
                 result['threads'] = result['threads'] + cpu['max_threads'];
             } else {
-                result['threads'] = result['threads'] + 1;
-            };
-            if (is_defined(cpu['cores'])) {
-                result['cores'] = result['cores'] + cpu['cores'];
-            } else {
-                result['cores'] = result['cores'] + 1;
+                result['threads'] = result['threads'] + cpu['cores'];
             };
         };
         debug('%s: num of CPUs=%d, num of cores=%d', OBJECT, length(hw_config['cpu']), cores);

diff --git a/quattor/types/hardware.pan b/quattor/types/hardware.pan
@@ -32,6 +32,12 @@ type structure_cpu = {
         deprecated(0, 'The hyperthreading cpu property has been deprecated, please migrate to max_threads');
         true;
     }
+} with {
+    if (exists(SELF['max_threads']) && SELF['max_threads'] < SELF['cores']) {
+        error("Number of execution threads (max_threads) cannot be less than number of CPU cores (cores)");
+    } else {
+        true;
+    };
 };