Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quattor/functions/network copy_network_params: bootproto=none for unconfigured interfaces #235

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Nov 12, 2024

  • Required for nmstate to work properly for unconfigured interfaces

I mark this PR as backward incompatible as it changes the resulting profile compared to previous version but I think it fixes something that was wrong but working with initscripts (because they don't care about interfaces not enabled on boot).

@jouvin jouvin added this to the 24.10 milestone Nov 12, 2024
@jouvin jouvin requested a review from jrha November 12, 2024 10:26
@jouvin jouvin force-pushed the interface_bootproto_default_none branch from 6291253 to 0673d29 Compare November 12, 2024 10:36
@jouvin
Copy link
Contributor Author

jouvin commented Nov 12, 2024

The panlint error is due to a variable called MTU, a too short name. I'd prefer to keep it to avoid breaking backward compatibility but if you prefer to do it, it should not be too much an issue for GRIF... If we keep it, is there a magic line to avoid checking this name and raising an error?

@jrha
Copy link
Member

jrha commented Nov 12, 2024

I'd prefer if it were called something less ambiguous like INTERFACE_MTU, I've checked and we don't use it at RAL.

@jrha
Copy link
Member

jrha commented Nov 12, 2024

I don't think I've shared it before, but we use this simple script for situations where we need to rename something globally: https://gist.github.com/jrha/f8373418cac4ed2ad6f5e5be08d096c3

@jouvin
Copy link
Contributor Author

jouvin commented Nov 12, 2024

Ok, I'll do it.

@jrha
Copy link
Member

jrha commented Nov 12, 2024

Thanks!

@jrha jrha changed the title quattor/functions/network copy_network_params(Ã): bootproto=none for unconfigured interfaces quattor/functions/network copy_network_params: bootproto=none for unconfigured interfaces Nov 12, 2024
@jrha
Copy link
Member

jrha commented Nov 12, 2024

Can you remove the (Ã) from the commit message?

@jouvin
Copy link
Contributor Author

jouvin commented Nov 12, 2024

Sure!

@jouvin jouvin force-pushed the interface_bootproto_default_none branch from 0673d29 to 17d7af3 Compare November 12, 2024 12:47
@jouvin
Copy link
Contributor Author

jouvin commented Nov 12, 2024

Should be ok now...

@jrha jrha merged commit ab2da25 into quattor:master Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants