Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take cluster-type as config instead of setting it from client calls #379

Open
shubhamtagra opened this issue May 8, 2020 · 0 comments
Open

Comments

@shubhamtagra
Copy link

This is needed to minimize need of fs classes. Today cluster-type is provided by client in FS which means that there is duplication of FS code across rubix-presto and rubix-hadoop. With cluster-type being provided via config, we can have common module for all FS implementations unless some engine needs specific ones like PrestoS3FS.

This was already done as part of c56fc21 but this commit was later reverted. We can bring back only the cluster-type part from this commit and make changes to have common rubix-fs module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant