-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema version comment doesn't end up in Rails structure.sql #363
Comments
Looks like this was already changed in Rails: We're currently on Rails 7.0.2 which has Might be worth mentioning in the Readme, to help people running into the same issue? |
Gonna close this issue as it has been fixed in Rails 7.0.3 so it won't be a problem with new users anymore. Existing users should be able to find this issue and resolution through the search function. |
I believe we just had another user get stung by this, noted in #376. Here's where the Rails bug was: introduced, resolved. The fix was indeed released in Rails 7.0.3. Going by the Git tags shown in the commit that introduced the issue, it looks like the issue affects every version of Rails 7 prior to 7.0.3: I wonder if we should not just document it, but add code to detect the lack of schema version comment and warn/raise! |
While investigating possible reasons for #350 I was checking whether the DB schema was up-to-date and noticed that que keeps it on a table comment.
Unfortunately this comment doesn't end up in Rails'
structure.sql
so it isn't added to new systems (includingdevelopment
andtest
databases) that runrake db:structure:load
to prepare the database.At first glance, there seem to be two possible solutions: get Rails to dump comments (might have additional benefits because one could use them to document the schema) or introduce a separate version column or table for que (less dependencies and reliance on specific Rails behaviour).
The text was updated successfully, but these errors were encountered: