Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation example fails #404

Open
jo-fleck opened this issue Aug 8, 2021 · 4 comments
Open

Documentation example fails #404

jo-fleck opened this issue Aug 8, 2021 · 4 comments

Comments

@jo-fleck
Copy link

jo-fleck commented Aug 8, 2021

I am trying to reproduce an example from the documentation.

However, I get this error:

ArgumentError: Invalid shortcut string
tokenize_shorthand(s::String) at shorthandparser.jl:13
parse_shortcut(s::String) at shorthandparser.jl:66
fix_shortcut_level_encoding at dsl_vlplot_function.jl:26 [inlined]
(::VegaLite.var"#17#23"{Vector{Pair{Symbol, AbstractVector{T} where T}}})(::Pair{String, String}) at none:0
iterate at generator.jl:47 [inlined]
OrderedCollections.OrderedDict{String, Any}(kv::Base.Generator{OrderedCollections.OrderedDict{String, Any}, VegaLite.var"#17#23"{Vector{Pair{Symbol, AbstractVector{T} where T}}}}) at ordered_dict.jl:26
fix_shortcut_level_spec(spec_frag::VegaLite.VLFrag) at dsl_vlplot_function.jl:170
top-level scope at plot_test_del.jl:8
eval at boot.jl:360 [inlined]

My specs:

  • VegaDatasets v2.1.1
  • VegaLite v2.6.0
  • versioninfo()
    Julia Version 1.6.0
    Commit f9720dc2eb (2021-03-24 12:55 UTC)
    Platform Info:
    OS: macOS (x86_64-apple-darwin19.6.0)
    CPU: Intel(R) Core(TM) i5-5287U CPU @ 2.90GHz
    WORD_SIZE: 64
    LIBM: libopenlibm
    LLVM: libLLVM-11.0.1 (ORCJIT, broadwell)
    Environment:
    JULIA_EDITOR = atom -a
    JULIA_NUM_THREADS = 4
@ericqu
Copy link
Contributor

ericqu commented Oct 15, 2021

I am guessing that you should change the line:

description="the population per state, engineers per state, and hurricanes per state",

by

title="The population per state, engineers per state, and hurricanes per state",

When I do that it works for me.

@jeremiahpslewis
Copy link
Contributor

@ericqu Would you consider submitting a PR with this change?

@ericqu ericqu mentioned this issue Oct 16, 2021
@ericqu
Copy link
Contributor

ericqu commented Oct 16, 2021

@jeremiahpslewis I hope I did it correctly; let me know If I should change something.

@jeremiahpslewis
Copy link
Contributor

Thanks! Looks good. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants