add check on empty strings to prevent StringIndexOutOfBoundsException (…

…#26)
quick-perf · Oct 25, 2022 · bee9005 · bee9005
1 parent 9bf36e0
commit bee9005
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/spring-boot-2/src/main/java/org/quickperf/web/spring/QuickPerfAfterRequestServletFilter.java b/spring-boot-2/src/main/java/org/quickperf/web/spring/QuickPerfAfterRequestServletFilter.java
@@ -33,6 +33,7 @@
 import org.springframework.core.annotation.Order;
 import org.springframework.stereotype.Component;
 import org.qstd.QuickSqlTestData;
+import org.springframework.util.StringUtils;
 
 import javax.servlet.*;
 import javax.servlet.http.HttpServletRequest;
@@ -195,12 +196,14 @@ private void quickPerfProcessing(HttpServletRequest httpServletRequest, HttpServ
         }
 
         if (databaseConfig.isSqlDisplayed()) {
-            infoReport.append(lineSeparator());
-            infoReport.append("* SQL");
-            infoReport.append(lineSeparator());
             String sqlExecutionsAsString = sqlExecutions.toString();
-            String sqlExecutionsWithoutThreeLastLineBreaks = sqlExecutionsAsString.substring(0, sqlExecutionsAsString.length() - 3);
-            infoReport.append(sqlExecutionsWithoutThreeLastLineBreaks);
+            if(!StringUtils.isEmpty(sqlExecutionsAsString)) {
+                infoReport.append(lineSeparator());
+                infoReport.append("* SQL");
+                infoReport.append(lineSeparator());
+                String sqlExecutionsWithoutThreeLastLineBreaks = sqlExecutionsAsString.substring(0, sqlExecutionsAsString.length() - 3);
+                infoReport.append(sqlExecutionsWithoutThreeLastLineBreaks);
+            }
         }
 
         if (databaseConfig.isDatabaseConnectionProfiled()) {