-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unsigned 64-bit integers for sequence numbers #621
Comments
Note to self:
|
FIX 4.3 added a “datatype” of SeqNum |
Thanks @JohnGreenan |
(at least) one more thing: database setup scripts need to change (and to check which data types need to be chosen). E.g. Postgres script only has One more other thing: as written here https://docs.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html the
|
In general I think changing the data type should not affect most users because the seqnum fields shouldn't be processed by user applications anyway. Maybe for logging or monitoring?! |
Another thing to take care of: getting messages from the store for resends is usually done through some kind of list with max capacity of Integer.MAX_VALUE. But getting such large lists should probably be forbidden anyway to guard against OOME. |
I'd have saved myself some bother had I fixed the aside you pointed out above! As it is the above issue covers the resend problems. |
Is your feature request related to a problem? Please describe.
Per https://www.fixtrading.org/groups/continuousmkts/
Sequence number resets are a bore.
Describe the solution you'd like
The implementation proposed is to use an unsigned 64 bit integer for a sequence number.
Using 1 billion sequence numbers per second, that will last for 584 years until they run out.
So we can leave the problem to our great, great, great (more) grandchildren to solve!
Describe alternatives you've considered
See attached "Continuous Markets WG- 24x7 FIX Best Practise Working Draft_v0.014.docx"
Additional context
Add any other context or screenshots about the feature request here.
Continuous Markets WG- 24x7 FIX Best Practise Working Draft_v0.014.docx
The text was updated successfully, but these errors were encountered: