Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configLocation value #114

Open
katlim-br opened this issue Nov 29, 2024 · 2 comments
Open

Use configLocation value #114

katlim-br opened this issue Nov 29, 2024 · 2 comments
Assignees

Comments

@katlim-br
Copy link

Many lines of the charts refer to the /quickwit/node.yaml hardcoded path.

However, I think they should refer to the configLocation variable.

BEFORE:
Example

        volumeMounts:
          - name: config
            mountPath: /quickwit/node.yaml

FIXED:

        volumeMounts:
          - name: config
            mountPath: {{ $.Values.configLocation }}

(For the subPath field, it could be replaced to be dynamic and use the Helm function "base")

@katlim-br
Copy link
Author

added this PR, and tested it locally #116

@fulmicoton
Copy link
Contributor

@rdettai can you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants