Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filebacked metastore default config in values.yaml #39

Closed
fmassot opened this issue Apr 5, 2023 · 3 comments
Closed

Add filebacked metastore default config in values.yaml #39

fmassot opened this issue Apr 5, 2023 · 3 comments
Assignees

Comments

@fmassot
Copy link
Contributor

fmassot commented Apr 5, 2023

No description provided.

@imotov
Copy link
Collaborator

imotov commented Apr 13, 2023

I was about to open an issue for that 😄 I can take a look at this as a follow up for quickwit-oss/quickwit#3164.

@fmassot
Copy link
Contributor Author

fmassot commented Apr 13, 2023

That would be great. The PR #43 tries to solve the issue by defining the metastore_uri but... adding a metastore uri is bit confusing when you define a postgres config. We probably want some validation too (#44).

This is what I have in mind:

config:
  metastore:
    # Define the URI.
    uri: s3://bucket/indexes 
    # uri: postgres://username:password@host:port/database 
    # You  can also define a postgres metastore like this
    # postgres:
    #   host: ""
    #   port: 5432
    #   database: metastore
    #   username: quickwit
    #   password: ""

Honestly, I would prefer removing the postgres and keep only a metastore_uri variable, @clemcvlcs any thoughts on this?

@fmassot
Copy link
Contributor Author

fmassot commented May 29, 2023

@imotov I just added a metastore_uri. I need to add some validation to avoid a user setting both metastore_uri and postgres.

@fmassot fmassot closed this as completed May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants