From eb3ffe5f8b63a0f5e6f79380bd929e0799c402aa Mon Sep 17 00:00:00 2001
From: JulesVautier-io <jules.vautier01@gmail.com>
Date: Thu, 20 Jun 2024 18:40:06 +0200
Subject: [PATCH] Fix Eslint errors

---
 .../components/QueryEditor/AggregationEditor.tsx  |  1 -
 .../components/SearchResult/AggregationResult.tsx |  1 -
 .../src/components/SearchResult/SearchResult.tsx  | 15 ++++++++-------
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx b/quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx
index 98d97a19ac2..6512e83ffca 100644
--- a/quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx
+++ b/quickwit/quickwit-ui/src/components/QueryEditor/AggregationEditor.tsx
@@ -98,7 +98,6 @@ export function MetricKind(props: SearchComponentProps) {
 }
 
 export function AggregationKind(props: SearchComponentProps) {
-  props;
   const defaultAgg  = {
     histogram: {
       interval: "1d",
diff --git a/quickwit/quickwit-ui/src/components/SearchResult/AggregationResult.tsx b/quickwit/quickwit-ui/src/components/SearchResult/AggregationResult.tsx
index 8649eeae750..e5d137c1f61 100644
--- a/quickwit/quickwit-ui/src/components/SearchResult/AggregationResult.tsx
+++ b/quickwit/quickwit-ui/src/components/SearchResult/AggregationResult.tsx
@@ -47,7 +47,6 @@ export function AggregationResult({searchResponse}: {searchResponse: SearchRespo
           data: line.value,
        };
     });
-    series;
     // we don't customize colors because we would need a full palette.
     return (
     <LineChart
diff --git a/quickwit/quickwit-ui/src/components/SearchResult/SearchResult.tsx b/quickwit/quickwit-ui/src/components/SearchResult/SearchResult.tsx
index 40a0d93a153..15744154c82 100644
--- a/quickwit/quickwit-ui/src/components/SearchResult/SearchResult.tsx
+++ b/quickwit/quickwit-ui/src/components/SearchResult/SearchResult.tsx
@@ -56,13 +56,6 @@ interface SearchResultProps {
 }
 
 export default function SearchResult(props: SearchResultProps) {
-  if (props.queryRunning) {
-    return <Loader />;
-  }
-  if (props.searchError !== null) {
-    return ErrorResponseDisplay(props.searchError);
-  }
-
   const result = useMemo(() => {
     if (props.searchResponse == null || props.index == null) {
       return null;
@@ -73,6 +66,14 @@ export default function SearchResult(props: SearchResultProps) {
     }
   }, [props.searchResponse, props.index]);
 
+  if (props.queryRunning) {
+    return <Loader />;
+  }
+  
+  if (props.searchError !== null) {
+    return ErrorResponseDisplay(props.searchError);
+  }
+
   if (props.searchResponse == null || props.index == null) {
     return <></>;
   }