Increase default warmup memory

quickwit-oss · Dec 2, 2024 · edfc0b1 · edfc0b1
1 parent c3de281
commit edfc0b1
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/quickwit/quickwit-config/src/node_config/mod.rs b/quickwit/quickwit-config/src/node_config/mod.rs
@@ -276,8 +276,8 @@ impl Default for SearcherConfig {
             split_cache: None,
             request_timeout_secs: Self::default_request_timeout_secs(),
             storage_timeout_policy: None,
-            warmup_memory_budget: ByteSize::gb(1),
-            warmup_single_split_initial_allocation: ByteSize::mb(50),
+            warmup_memory_budget: ByteSize::gb(10),
+            warmup_single_split_initial_allocation: ByteSize::gb(1),
         }
     }
 }

diff --git a/quickwit/quickwit-config/src/node_config/serialize.rs b/quickwit/quickwit-config/src/node_config/serialize.rs
@@ -617,8 +617,8 @@ mod tests {
                     timeout_millis: 2_000,
                     max_num_retries: 2
                 }),
-                warmup_memory_budget: ByteSize::gb(1),
-                warmup_single_split_initial_allocation: ByteSize::mb(50),
+                warmup_memory_budget: ByteSize::gb(10),
+                warmup_single_split_initial_allocation: ByteSize::gb(50),
             }
         );
         assert_eq!(

diff --git a/quickwit/quickwit-search/src/root.rs b/quickwit/quickwit-search/src/root.rs
@@ -1156,7 +1156,7 @@ async fn refine_and_list_matches(
 /// 2. Merges the search results.
 /// 3. Sends fetch docs requests to multiple leaf nodes.
 /// 4. Builds the response with docs and returns.
-#[instrument(skip_all, fields(request_id))]
+#[instrument(skip_all)]
 pub async fn root_search(
     searcher_context: &SearcherContext,
     mut search_request: SearchRequest,

diff --git a/quickwit/quickwit-search/src/search_permit_provider.rs b/quickwit/quickwit-search/src/search_permit_provider.rs
@@ -146,7 +146,6 @@ impl SearchPermitActor {
                 self.assign_available_permits();
                 permit_sender
                     .send(permits)
-                    .ok()
                     // This is a request response pattern, so we can safely ignore the error.
                     .expect("Receiver lives longer than sender");
             }