Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually support the format option in the ES API's RangeQuery #5109

Closed
fulmicoton opened this issue Jun 12, 2024 · 1 comment
Closed

Actually support the format option in the ES API's RangeQuery #5109

fulmicoton opened this issue Jun 12, 2024 · 1 comment
Assignees
@etolbakov
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fulmicoton
Copy link
Contributor

fulmicoton commented Jun 12, 2024 •
edited
Loading

the parameter is introduced in #5098, but is noop at the moment.

https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-range-query.html
It makes it possible for the client to pass dates in a specific format
https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-date-format.html
@fulmicoton fulmicoton added enhancement New feature or request good first issue Good for newcomers labels Jun 12, 2024
@fulmicoton fulmicoton changed the title Actually support the format option in RangeQuery Actually support the format option in the ES API's RangeQuery Jun 12, 2024
@fulmicoton
Copy link
Contributor Author

It can be done by doing the conversion in the elastic search dsl range query (quickwit-query/src/elastic_query_dsl/range_query.rs)
and reserializing it into rfc3339 before creating the QueryASt's range query.

This was referenced Jul 9, 2024
Closed
Merged
@etolbakov etolbakov mentioned this issue Jul 17, 2024
Closed
@fulmicoton fulmicoton moved this to In progress in Quickwit 0.9 Jul 27, 2024
@kuzaxak kuzaxak mentioned this issue Sep 28, 2024
Closed
@github-project-automation github-project-automation bot moved this from In progress to Done in Quickwit 0.9 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etolbakov etolbakov

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Quickwit 0.9
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fulmicoton @etolbakov